You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (Created) (JIRA)" <ji...@apache.org> on 2012/02/09 17:46:02 UTC
[jira] [Created] (HBASE-5363) Add rat check to run automatically on
mvn build.
Add rat check to run automatically on mvn build.
------------------------------------------------
Key: HBASE-5363
URL: https://issues.apache.org/jira/browse/HBASE-5363
Project: HBase
Issue Type: Improvement
Components: build
Affects Versions: 0.92.0, 0.90.5
Reporter: Jonathan Hsieh
Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
Here's an example from Whirr:
https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5363:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed 0.90 and 0.92 branches as well as to trunk
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204719#comment-13204719 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
The rat site suggests running it in the mvn verify phase.
http://incubator.apache.org/rat/apache-rat-plugin/examples/verify.html
I added the chunk above and rat didn't seem to be run or fail the build. Investigating further to figure out which phase seems reasonable..
As an aside, we should probably update the http://wiki.apache.org/hadoop/Hbase/HowToRelease wiki page now that the build has diverged from hadoop's now (we don't have any ant).
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204688#comment-13204688 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
.. fails the tarballs when being built ('mvn package').
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206685#comment-13206685 ]
Hudson commented on HBASE-5363:
-------------------------------
Integrated in HBase-0.92 #277 (See [https://builds.apache.org/job/HBase-0.92/277/])
HBASE-5363 Automatically run rat check on mvn release builds (Revision 1243163)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/pom.xml
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205004#comment-13205004 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
To run, us 'mvn package -Prelease -DskipTests'. Note that the excludes are not used if you use 'mvn rat:check'. I need help from a mavenista to figure out how to make that work without copy paste.
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: HBASE-5363-1.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204687#comment-13204687 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
Stack. I see but I believe the part that I want to add is the part that executes it (executions section) and fails the tarballs are built ('mvn package').
{code}
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<version>0.8</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
{code}
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5363:
----------------------------------
Attachment: (was: HBASE-5363-1.patch)
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5363:
----------------------------------
Attachment: hbase-5363-0.90.patch
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205887#comment-13205887 ]
stack commented on HBASE-5363:
------------------------------
Whats your hadoop wikiid Jon?
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5363:
----------------------------------
Summary: Automatically run rat check on mvn release builds (was: Add rat check run automatically on mvn release build.)
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: HBASE-5363-1.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205023#comment-13205023 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
patch applies on 0.92, reports 1 error (src/docbkx/build.xml)
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207117#comment-13207117 ]
Hudson commented on HBASE-5363:
-------------------------------
Integrated in HBase-TRUNK #2660 (See [https://builds.apache.org/job/HBase-TRUNK/2660/])
HBASE-5363 Automatically run rat check on mvn release builds (Revision 1243164)
Result = FAILURE
stack :
Files :
* /hbase/trunk/pom.xml
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "Elliott Clark (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204736#comment-13204736 ]
Elliott Clark commented on HBASE-5363:
--------------------------------------
Attached a patch to add headers to some files that were missing it according to rat.
I couldn't get the rat plugin to run automatically on the first try so the patch doesn't have any pom changes in it.
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: HBASE-5363-1.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205941#comment-13205941 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
Thanks! Works. Updated wiki.
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Add rat check run automatically on
mvn release build.
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5363:
----------------------------------
Summary: Add rat check run automatically on mvn release build. (was: Add rat check to run automatically on mvn build.)
> Add rat check run automatically on mvn release build.
> -----------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: HBASE-5363-1.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204723#comment-13204723 ]
stack commented on HBASE-5363:
------------------------------
The rat plugin is pretty crappy in my experience too. Its hard to get it behave.
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5363:
----------------------------------
Fix Version/s: 0.92.1
0.90.6
0.94.0
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "Jonathan Hsieh (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh reassigned HBASE-5363:
-------------------------------------
Assignee: Jonathan Hsieh
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206695#comment-13206695 ]
Hudson commented on HBASE-5363:
-------------------------------
Integrated in HBase-TRUNK-security #109 (See [https://builds.apache.org/job/HBase-TRUNK-security/109/])
HBASE-5363 Automatically run rat check on mvn release builds (Revision 1243164)
Result = FAILURE
stack :
Files :
* /hbase/trunk/pom.xml
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205744#comment-13205744 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
Figured it out. Kind of evil.
'mvn rat:check' is wrong.
you are supposed to use
'mvn apache-rat:check'.
I'm tried to update this wiki but don't have perms:
http://wiki.apache.org/hadoop/Hbase/HowToRelease
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205924#comment-13205924 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
JonathanHsieh
Sent from my iPhone
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205093#comment-13205093 ]
Hadoop QA commented on HBASE-5363:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12514046/hbase-5363.2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -136 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/933//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/933//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/933//console
This message is automatically generated.
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205011#comment-13205011 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
@Elliott, since you posted on the other jira, I deleted the attachment that you placed here.
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205033#comment-13205033 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
made a 0.90 version, reports about 40 errors (probably similar to the 0.92 branch errors)
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "Elliott Clark (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204728#comment-13204728 ]
Elliott Clark commented on HBASE-5363:
--------------------------------------
Though it is getting several files that need licenses.
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5363:
----------------------------------
Attachment: hbase-5363.patch
This patch adds rat checks to the package phase of the mvn build when the release profile is activated (-Prelease).
It cleans up some of the rat excludes (ignore auto gen stuff), and at least on trunk id's 5 legit license violations.
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: HBASE-5363-1.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205937#comment-13205937 ]
stack commented on HBASE-5363:
------------------------------
Try it now boss....
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212147#comment-13212147 ]
Hudson commented on HBASE-5363:
-------------------------------
Integrated in HBase-0.92-security #91 (See [https://builds.apache.org/job/HBase-0.92-security/91/])
HBASE-5363 Automatically run rat check on mvn release builds (Revision 1243163)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/pom.xml
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204671#comment-13204671 ]
stack commented on HBASE-5363:
------------------------------
We already have this. See our pom:
{code}
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<version>0.7</version>
<configuration>
<excludes>
<exclude>**/.*</exclude>
<exclude>**/target/**</exclude>
<exclude>**/CHANGES.txt</exclude>
<exclude>**/CHANGES.txt</exclude>
<exclude>**/generated/**</exclude>
<exclude>**/conf/*</exclude>
<exclude>**/*.avpr</exclude>
<exclude>**/control</exclude>
<exclude>**/conffile</exclude>
<exclude>**/8e8ab58dcf39412da19833fcd8f687ac</exclude>
<!--It don't like freebsd license-->
<exclude>src/site/resources/css/freebsd_docbook.css</exclude>
</excludes>
</configuration>
</plugin>
{code}
And see the generated report: http://hbase.apache.org/rat-report.html
Here is the issue where I messed w/ this stuff on trunk: HBASE-4647
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204695#comment-13204695 ]
Todd Lipcon commented on HBASE-5363:
------------------------------------
Can we enable this only with a -Prelease build? Or part of the assembly phase? The package phase runs for every "mvn install", which is already super slow.. I think we could move this and the source jar generation to a different phase, or selectively enable with a -Prelease profile?
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5363:
----------------------------------
Status: Patch Available (was: Open)
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0, 0.90.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn
release builds
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5363:
----------------------------------
Attachment: hbase-5363.2.patch
v2 of the trunk/0.92 patch. v1 likely breaks website report generation.
> Automatically run rat check on mvn release builds
> -------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5363-0.90.patch, hbase-5363.2.patch, hbase-5363.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically
on mvn build.
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204846#comment-13204846 ]
Jonathan Hsieh commented on HBASE-5363:
---------------------------------------
Hey Elliott, thanks for the patch! Let me ask a favor -- could you post the license fixes patch to this jira HBASE-5364?
Thanks!
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: HBASE-5363-1.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5363) Add rat check to run automatically on
mvn build.
Posted by "Elliott Clark (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-5363:
---------------------------------
Attachment: HBASE-5363-1.patch
> Add rat check to run automatically on mvn build.
> ------------------------------------------------
>
> Key: HBASE-5363
> URL: https://issues.apache.org/jira/browse/HBASE-5363
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: HBASE-5363-1.patch
>
>
> Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future.
> Here's an example from Whirr:
> https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira