You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "kayx23 (via GitHub)" <gi...@apache.org> on 2023/04/13 08:29:04 UTC
[GitHub] [apisix] kayx23 opened a new pull request, #9303: docs: fix admonition in Terminology, Secret
kayx23 opened a new pull request, #9303:
URL: https://github.com/apache/apisix/pull/9303
## Before
https://apisix.apache.org/docs/apisix/terminology/secret/
## After
See changed file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on pull request #9303: docs: fix admonition in Terminology, Secret
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on PR #9303:
URL: https://github.com/apache/apisix/pull/9303#issuecomment-1510983044
@kayx23 I hope so, since the preview is being generated from v3.2 & not from master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on pull request #9303: docs: fix admonition in Terminology, Secret
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on PR #9303:
URL: https://github.com/apache/apisix/pull/9303#issuecomment-1511031911
I think it's better to push the content to v3.2 & run a cron to migrate files (docs) to the master asynchronously, but yeah I also feel the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 commented on pull request #9303: docs: fix admonition in Terminology, Secret
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #9303:
URL: https://github.com/apache/apisix/pull/9303#issuecomment-1511009805
That's actually quite annoying innit?! Have to open two PRs for the same change? I wonder how many people have committed doc improvements but to the wrong branch....
I was told I shouldn't commit to a specific version, say 3.2, because the change won't be carried over unless I commit to master......
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Gallardot merged pull request #9303: docs: fix admonition in Terminology, Secret
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot merged PR #9303:
URL: https://github.com/apache/apisix/pull/9303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 commented on pull request #9303: docs: fix admonition in Terminology, Secret
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #9303:
URL: https://github.com/apache/apisix/pull/9303#issuecomment-1506649949
Thanks. Merge?
> Only those with [write access](https://docs.github.com/articles/what-are-the-different-access-permissions) to this repository can merge pull requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 commented on pull request #9303: docs: fix admonition in Terminology, Secret
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #9303:
URL: https://github.com/apache/apisix/pull/9303#issuecomment-1511037172
Maybe we should open a discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 commented on pull request #9303: docs: fix admonition in Terminology, Secret
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #9303:
URL: https://github.com/apache/apisix/pull/9303#issuecomment-1510935573
Anybody know why the change is not reflected on the website? I'm still seeing the OG version which is not properly formatted:
https://apisix.apache.org/docs/apisix/terminology/secret/
Confused. Does this mean if I spot a problem on version 3.2, I should commit my change to BOTH version 3.2 and master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org