You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2026/04/01 04:01:13 UTC
[I] clippy `collapsible_match` error on rust nightly (1.96.0) [datafusion-comet]
manuzhang opened a new issue, #3862:
URL: https://github.com/apache/datafusion-comet/issues/3862
### Describe the bug
```
Checking datafusion-comet-spark-expr v0.15.0 (/Users/manuzhang/git/datafusion-comet/native/spark-expr)
error: this `if` can be collapsed into the outer `match`sion_comet_spark_expr(test), datafusion-comet-spark-expr
--> spark-expr/src/math_funcs/negative.rs:162:29
|
162 | / ... if value == Some(i8::MIN) {
163 | | ... return Err(arithmetic_overflow_error(" caused").into());
164 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
= note: `-D clippy::collapsible-match` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::collapsible_match)]`
help: collapse nested if block
|
161 ~ ScalarValue::Int8(value)
162 ~ if value == Some(i8::MIN) => {
163 | return Err(arithmetic_overflow_error(" caused").into());
164 ~ }
|
error: this `if` can be collapsed into the outer `match`
--> spark-expr/src/math_funcs/negative.rs:167:29
|
167 | / ... if value == Some(i16::MIN) {
168 | | ... return Err(arithmetic_overflow_error(" caused").into());
169 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
help: collapse nested if block
|
166 ~ ScalarValue::Int16(value)
167 ~ if value == Some(i16::MIN) => {
168 | return Err(arithmetic_overflow_error(" caused").into());
169 ~ }
|
error: this `if` can be collapsed into the outer `match`
--> spark-expr/src/math_funcs/negative.rs:172:29
|
172 | / ... if value == Some(i32::MIN) {
173 | | ... return Err(arithmetic_overflow_error("integer").into());
174 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
help: collapse nested if block
|
171 ~ ScalarValue::Int32(value)
172 ~ if value == Some(i32::MIN) => {
173 | return Err(arithmetic_overflow_error("integer").into());
174 ~ }
|
error: this `if` can be collapsed into the outer `match`
--> spark-expr/src/math_funcs/negative.rs:177:29
|
177 | / ... if value == Some(i64::MIN) {
178 | | ... return Err(arithmetic_overflow_error("long").into());
179 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
help: collapse nested if block
|
176 ~ ScalarValue::Int64(value)
177 ~ if value == Some(i64::MIN) => {
178 | return Err(arithmetic_overflow_error("long").into());
179 ~ }
|
error: this `if` can be collapsed into the outer `match`
--> spark-expr/src/math_funcs/negative.rs:189:29
|
189 | / ... if value == Some(i32::MIN) {
190 | | ... return Err(arithmetic_overflow_error("interval").into());
191 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
help: collapse nested if block
|
188 ~ ScalarValue::IntervalYearMonth(value)
189 ~ if value == Some(i32::MIN) => {
190 | return Err(arithmetic_overflow_error("interval").into());
191 ~ }
|
error: could not compile `datafusion-comet-spark-expr` (lib) due to 5 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `datafusion-comet-spark-expr` (lib test) due to 5 previous errors
```
### Steps to reproduce
```
rustup override set nightly
cargo clippy --color=never --all-targets --workspace -- -D warnings
```
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] clippy `collapsible_match` error on rust nightly (1.96.0) [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura closed issue #3862: clippy `collapsible_match` error on rust nightly (1.96.0)
URL: https://github.com/apache/datafusion-comet/issues/3862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org