You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2016/07/06 10:13:26 UTC

[GitHub] spark pull request #14067: [SPARK-16371][SQL] Do not push down filters incor...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/14067

    [SPARK-16371][SQL] Do not push down filters incorrectly when inner name and outer name are the same in Parquet

    ## What changes were proposed in this pull request?
    
    Currently, if there is a schema as below:
    
    ```
    root
      |-- _1: struct (nullable = true)
      |    |-- _1: string (nullable = true)
    ```
    
    and if we execute the codes below:
    
    ```scala
    df.filter("_1 IS NOT NULL").count()
    ```
    
    pushes down a filter although this filter is being applied to `StructType`.(If my understanding is correct, Spark does not pushes down filters for those).
    
    The reason is, `ParquetFilters.getFieldMap` produces results below:
    
    ```
    (_1,StructType(StructField(_1,IntegerType,true)))
    (_1,IntegerType)
    ```
    
    and then it becomes a `Map`
    
    ```
    (_1,IntegerType)
    ```
    
    Now, because of ` ....lift(dataTypeOf(name)).map(_(name, value))`, this pushes down filters for `_1` which Parquet thinks is `IntegerType`. However, it is actually `StructType`.
    
    So, Parquet filter2 is failed and then
    
    ```
    df.filter("_1 IS NOT NULL").count()
    ```
    
    produces 0.
    
    
    This PR prevents this by pre-checking supported types for Parquet filter push down. 
    
    ## How was this patch tested?
    
    Unit test in `ParquetFilterSuite`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-16371

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14067
    
----
commit 54b834838c1855fcea0d108b19b89119fe351618
Author: hyukjinkwon <gu...@gmail.com>
Date:   2016-07-06T10:00:53Z

    Do not push down filters incorrectly when inner name and outer name are the same

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14067: [SPARK-16371][SQL] Do not push down filters incorrectly ...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/14067
  
    Oh, @liancheng I just corrected some more. Please take another look..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14067: [SPARK-16371][SQL] Do not push down filters incorrectly ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14067
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61843/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14067: [SPARK-16371][SQL] Do not push down filters incorrectly ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14067
  
    **[Test build #61843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61843/consoleFull)** for PR 14067 at commit [`1300042`](https://github.com/apache/spark/commit/1300042fc266843b966923201f52e193e490ddaf).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14067: [SPARK-16371][SQL] Do not push down filters incorrectly ...

Posted by viirya <gi...@git.apache.org>.

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/14067
  
    The description seems incorrect. It should be a StringType, instead of IntegerType?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14067: [SPARK-16371][SQL] Do not push down filters incorrectly ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14067
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14067: [SPARK-16371][SQL] Do not push down filters incorrectly ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14067
  
    **[Test build #61842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61842/consoleFull)** for PR 14067 at commit [`ffaa666`](https://github.com/apache/spark/commit/ffaa666673e91a771f1d58267d085483ed68e56c).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14067: [SPARK-16371][SQL] Do not push down filters incorrectly ...

Posted by liancheng <gi...@git.apache.org>.

Github user liancheng commented on the issue:

    https://github.com/apache/spark/pull/14067
  
    LGTM pending Jenkins.
    
    2.0.0 RC2 has already been cut. We may have this in 2.0.0 if there was another RC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org