You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/03 15:57:54 UTC
[GitHub] eolivelli commented on a change in pull request #936: Issue 897: un-bind zookeeper from bookkeeper admin
eolivelli commented on a change in pull request #936: Issue 897: un-bind zookeeper from bookkeeper admin
URL: https://github.com/apache/bookkeeper/pull/936#discussion_r159456110
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
##########
@@ -724,15 +717,12 @@ int runCmd(CommandLine cmdLine) throws Exception {
@Override
public int runCmd(CommandLine cmdLine) throws Exception {
- ZooKeeper zk = null;
LedgerManagerFactory mFactory = null;
LedgerManager m = null;
try {
- zk = ZooKeeperClient.newBuilder()
- .connectString(bkConf.getZkServers())
- .sessionTimeoutMs(bkConf.getZkTimeout())
- .build();
- mFactory = LedgerManagerFactory.newLedgerManagerFactory(bkConf, zk);
+ mFactory = LedgerManagerFactory.newLedgerManagerFactory(
Review comment:
I think we are lacking some close().
You can considering even adding a close() method to LedgerManagerFactory and make it AutoCloseable in order to use try-with-resources
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services