You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "mdayakar (via GitHub)" <gi...@apache.org> on 2026/05/19 13:00:50 UTC
[PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
mdayakar opened a new pull request, #6500:
URL: https://github.com/apache/hive/pull/6500
HIVE-29609: HPL/SQL leaving behind hive-staging directories
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
When INSERT statements are executed in hplsql mode then the Hive statging directories under the table path are not getting deleted due to driver.close() is not getting called(which internally calls context.clear() which eventually deletes the staging directories under the table path) after the INSERT statement execution is successful in HPLSQL mode. As a part of fix now calling drive.close() which deletes the staging directories.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
To delete the staging directories present under table path.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Unit tests are added.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 merged PR #6500:
URL: https://github.com/apache/hive/pull/6500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6500:
URL: https://github.com/apache/hive/pull/6500#issuecomment-4490577094
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6500) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6500&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6500&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6500&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6500&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6500&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6500)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6500:
URL: https://github.com/apache/hive/pull/6500#issuecomment-4488961156
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6500) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6500&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6500&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6500&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6500&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6500&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6500)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
Posted by "mdayakar (via GitHub)" <gi...@apache.org>.
mdayakar commented on code in PR #6500:
URL: https://github.com/apache/hive/pull/6500#discussion_r3275854142
##########
service/src/test/org/apache/hive/service/cli/operation/TestSQLOperationDriverCleanup.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hive.service.cli.operation;
+
+import com.google.common.collect.ImmutableMap;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.IDriver;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.service.cli.HandleIdentifier;
+import org.apache.hive.service.cli.OperationState;
+import org.apache.hive.service.cli.SessionHandle;
+import org.apache.hive.service.cli.session.HiveSession;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.lang.reflect.Field;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class TestSQLOperationDriverCleanup {
+
+ private HiveSession session;
+ private IDriver driver;
+
+ @Before
+ public void setUp() {
+ HiveConf conf = new HiveConf();
+ session = mock(HiveSession.class);
+ when(session.getHiveConf()).thenReturn(conf);
+ when(session.getSessionState()).thenReturn(mock(SessionState.class));
+ when(session.getUserName()).thenReturn("user");
+ SessionHandle sessionHandle = mock(SessionHandle.class);
+ when(sessionHandle.getHandleIdentifier()).thenReturn(new HandleIdentifier());
+ when(session.getSessionHandle()).thenReturn(sessionHandle);
+ driver = mock(IDriver.class);
+ }
+
+ @Test
+ public void testSQLOperationCloseReleasesDriverInHPLSQLMode() throws Exception {
+ SQLOperation operation = new SQLOperation(session, "insert into test values (1)",
+ ImmutableMap.of(), false, 0L, true);
+ setDriver(operation, driver);
+
+ operation.close();
+
+ inOrder(driver).verify(driver).close();
+ inOrder(driver).verify(driver).destroy();
+ assertNull(getDriver(operation));
+ }
+
+ @Test
+ public void testSQLOperationCloseReleasesDriverInNonHPLSQLMode() throws Exception {
+ SQLOperation operation = new SQLOperation(session, "insert into test values (1)",
+ ImmutableMap.of(), false, 0L, false);
+ setDriver(operation, driver);
+
+ operation.close();
+
+ inOrder(driver).verify(driver).close();
+ inOrder(driver).verify(driver).destroy();
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #6500:
URL: https://github.com/apache/hive/pull/6500#discussion_r3268823587
##########
service/src/test/org/apache/hive/service/cli/operation/TestSQLOperationDriverCleanup.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hive.service.cli.operation;
+
+import com.google.common.collect.ImmutableMap;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.IDriver;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.service.cli.HandleIdentifier;
+import org.apache.hive.service.cli.OperationState;
+import org.apache.hive.service.cli.SessionHandle;
+import org.apache.hive.service.cli.session.HiveSession;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.lang.reflect.Field;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class TestSQLOperationDriverCleanup {
+
+ private HiveSession session;
+ private IDriver driver;
+
+ @Before
+ public void setUp() {
+ HiveConf conf = new HiveConf();
+ session = mock(HiveSession.class);
+ when(session.getHiveConf()).thenReturn(conf);
+ when(session.getSessionState()).thenReturn(mock(SessionState.class));
+ when(session.getUserName()).thenReturn("user");
+ SessionHandle sessionHandle = mock(SessionHandle.class);
+ when(sessionHandle.getHandleIdentifier()).thenReturn(new HandleIdentifier());
+ when(session.getSessionHandle()).thenReturn(sessionHandle);
+ driver = mock(IDriver.class);
+ }
+
+ @Test
+ public void testSQLOperationCloseReleasesDriverInHPLSQLMode() throws Exception {
+ SQLOperation operation = new SQLOperation(session, "insert into test values (1)",
+ ImmutableMap.of(), false, 0L, true);
+ setDriver(operation, driver);
+
+ operation.close();
+
+ inOrder(driver).verify(driver).close();
+ inOrder(driver).verify(driver).destroy();
Review Comment:
Do we need to verify on the same `InOrder` object? Calling `inOrder` creates a new `InOrder` object every time. Maybe we need something like this?
```
InOrder order = inOrder(driver);
order.verify(driver).close();
order.verify(driver).destroy();
```
##########
service/src/test/org/apache/hive/service/cli/operation/TestSQLOperationDriverCleanup.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hive.service.cli.operation;
+
+import com.google.common.collect.ImmutableMap;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.IDriver;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.service.cli.HandleIdentifier;
+import org.apache.hive.service.cli.OperationState;
+import org.apache.hive.service.cli.SessionHandle;
+import org.apache.hive.service.cli.session.HiveSession;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.lang.reflect.Field;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class TestSQLOperationDriverCleanup {
+
+ private HiveSession session;
+ private IDriver driver;
+
+ @Before
+ public void setUp() {
+ HiveConf conf = new HiveConf();
+ session = mock(HiveSession.class);
+ when(session.getHiveConf()).thenReturn(conf);
+ when(session.getSessionState()).thenReturn(mock(SessionState.class));
+ when(session.getUserName()).thenReturn("user");
+ SessionHandle sessionHandle = mock(SessionHandle.class);
+ when(sessionHandle.getHandleIdentifier()).thenReturn(new HandleIdentifier());
+ when(session.getSessionHandle()).thenReturn(sessionHandle);
+ driver = mock(IDriver.class);
+ }
+
+ @Test
+ public void testSQLOperationCloseReleasesDriverInHPLSQLMode() throws Exception {
+ SQLOperation operation = new SQLOperation(session, "insert into test values (1)",
+ ImmutableMap.of(), false, 0L, true);
+ setDriver(operation, driver);
+
+ operation.close();
+
+ inOrder(driver).verify(driver).close();
+ inOrder(driver).verify(driver).destroy();
+ assertNull(getDriver(operation));
+ }
+
+ @Test
+ public void testSQLOperationCloseReleasesDriverInNonHPLSQLMode() throws Exception {
+ SQLOperation operation = new SQLOperation(session, "insert into test values (1)",
+ ImmutableMap.of(), false, 0L, false);
+ setDriver(operation, driver);
+
+ operation.close();
+
+ inOrder(driver).verify(driver).close();
+ inOrder(driver).verify(driver).destroy();
Review Comment:
Similar as above.
##########
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestHplSqlViaBeeLine.java:
##########
@@ -1480,6 +1485,28 @@ public void testERRORCODEForExecuteStatements() throws Throwable {
testScriptFile(scriptText, args(), "First ERRORCODE: -1.*Second ERRORCODE: 0", OutStream.ERR);
}
+ @Test
+ public void testHplSqlInsertRemovesStagingDirsUnderTable() throws Throwable {
+ String scriptText =
+ "DROP TABLE IF EXISTS result;\n" +
+ "CREATE TABLE result (s string);\n" +
+ "INSERT INTO result VALUES('Hello');\n" +
+ "execute 'INSERT INTO result VALUES(''World'')';\n" +
+ "SELECT * FROM result;";
+ testScriptFile(scriptText, args(), "Hello.*World");
+
+ HiveConf conf = miniHS2.getHiveConf();
+ String stagingDirPrefix = HiveConf.getVar(conf, HiveConf.ConfVars.STAGING_DIR);
+ Path wh = new Path(MetastoreConf.getVar(conf, MetastoreConf.ConfVars.WAREHOUSE));
+ FileSystem fs = wh.getFileSystem(conf);
+ Path tableDir = fs.makeQualified(new Path(wh, "result"));
+ FileStatus[] children = fs.listStatus(tableDir);
+ for (FileStatus child : children) {
Review Comment:
Is it possible for `children` to be null? It's fine if the array is empty but if it's null we may run into NPE here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6500:
URL: https://github.com/apache/hive/pull/6500#issuecomment-4503539773
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6500) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6500&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6500&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6500&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6500&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6500&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6500)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
Posted by "mdayakar (via GitHub)" <gi...@apache.org>.
mdayakar commented on code in PR #6500:
URL: https://github.com/apache/hive/pull/6500#discussion_r3275851938
##########
service/src/test/org/apache/hive/service/cli/operation/TestSQLOperationDriverCleanup.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hive.service.cli.operation;
+
+import com.google.common.collect.ImmutableMap;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.IDriver;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.service.cli.HandleIdentifier;
+import org.apache.hive.service.cli.OperationState;
+import org.apache.hive.service.cli.SessionHandle;
+import org.apache.hive.service.cli.session.HiveSession;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.lang.reflect.Field;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class TestSQLOperationDriverCleanup {
+
+ private HiveSession session;
+ private IDriver driver;
+
+ @Before
+ public void setUp() {
+ HiveConf conf = new HiveConf();
+ session = mock(HiveSession.class);
+ when(session.getHiveConf()).thenReturn(conf);
+ when(session.getSessionState()).thenReturn(mock(SessionState.class));
+ when(session.getUserName()).thenReturn("user");
+ SessionHandle sessionHandle = mock(SessionHandle.class);
+ when(sessionHandle.getHandleIdentifier()).thenReturn(new HandleIdentifier());
+ when(session.getSessionHandle()).thenReturn(sessionHandle);
+ driver = mock(IDriver.class);
+ }
+
+ @Test
+ public void testSQLOperationCloseReleasesDriverInHPLSQLMode() throws Exception {
+ SQLOperation operation = new SQLOperation(session, "insert into test values (1)",
+ ImmutableMap.of(), false, 0L, true);
+ setDriver(operation, driver);
+
+ operation.close();
+
+ inOrder(driver).verify(driver).close();
+ inOrder(driver).verify(driver).destroy();
Review Comment:
Fixed
##########
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestHplSqlViaBeeLine.java:
##########
@@ -1480,6 +1485,28 @@ public void testERRORCODEForExecuteStatements() throws Throwable {
testScriptFile(scriptText, args(), "First ERRORCODE: -1.*Second ERRORCODE: 0", OutStream.ERR);
}
+ @Test
+ public void testHplSqlInsertRemovesStagingDirsUnderTable() throws Throwable {
+ String scriptText =
+ "DROP TABLE IF EXISTS result;\n" +
+ "CREATE TABLE result (s string);\n" +
+ "INSERT INTO result VALUES('Hello');\n" +
+ "execute 'INSERT INTO result VALUES(''World'')';\n" +
+ "SELECT * FROM result;";
+ testScriptFile(scriptText, args(), "Hello.*World");
+
+ HiveConf conf = miniHS2.getHiveConf();
+ String stagingDirPrefix = HiveConf.getVar(conf, HiveConf.ConfVars.STAGING_DIR);
+ Path wh = new Path(MetastoreConf.getVar(conf, MetastoreConf.ConfVars.WAREHOUSE));
+ FileSystem fs = wh.getFileSystem(conf);
+ Path tableDir = fs.makeQualified(new Path(wh, "result"));
+ FileStatus[] children = fs.listStatus(tableDir);
+ for (FileStatus child : children) {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29609: HPL/SQL leaving behind hive-staging directories [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6500:
URL: https://github.com/apache/hive/pull/6500#issuecomment-4501941474
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6500) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6500&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6500&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6500&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6500&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6500&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6500)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org