You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/20 13:51:47 UTC

[GitHub] [arrow] sahil1105 commented on a change in pull request #10088: ARROW-10675 [C++][Python] Support AWS S3 Web identity credentials

sahil1105 commented on a change in pull request #10088:
URL: https://github.com/apache/arrow/pull/10088#discussion_r616703739



##########
File path: cpp/src/arrow/filesystem/s3fs.h
##########
@@ -91,6 +94,12 @@ struct ARROW_EXPORT S3Options {
   /// Whether OutputStream writes will be issued in the background, without blocking.
   bool background_writes = true;
 
+  /// True when using SimpleAWSCredentialsProvider, else false.
+  bool creds_provided = false;
+
+  /// True when using web identity token to assume role
+  bool use_web_identity = false;

Review comment:
       Yes, that'a good idea. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org