You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2016/01/06 17:23:39 UTC

[jira] [Resolved] (YETUS-269) In docker mode, git version check isn't needed prior to relaunching

     [ https://issues.apache.org/jira/browse/YETUS-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Busbey resolved YETUS-269.
-------------------------------
    Resolution: Won't Fix

The question I've been asking myself since yesterday: "How common will downstream users be that 1) rely solely on command line args, 2) are trying to deploy on OS-provided packages that only have older git, and 3) can successfully* install + run docker?"

If there's a set of folks that meet those requirements, they'll never hit re-exec mode and would benefit from a flag that essentially says to skip the git check. At the moment, I'm not actually one of those users. I *could* change to use command line args instead of a personality to work around the git version, if only because that feels less wrong than having my CI job install a local git version.

But this all seems unnecessarily complex compared to "upgrade the version of git on the CI infra," so I'm going to close as "won'tfix" unless someone else has an objection.

> In docker mode, git version check isn't needed prior to relaunching
> -------------------------------------------------------------------
>
>                 Key: YETUS-269
>                 URL: https://issues.apache.org/jira/browse/YETUS-269
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.1.0
>            Reporter: Sean Busbey
>            Priority: Minor
>
> we we're running in docker mode, we still bail out the build if the host OS has an old version of git. if everything is installed correctly, we'll be doing all of our git actions within the docker container, so we shouldn't be doing this check so early.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)