[jira] [Commented] (SOLR-10860) in-place updates currently throw NumberFormatException instead of a Bad Request SolrException for bad input

["Munendra S N (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775219#comment-16775219 ] 

Munendra S N commented on SOLR-10860:
-------------------------------------

 [^SOLR-10860.patch] 
Attached patch handles NFE and throws SolrException with 400 status code

[~ichattopadhyaya] [~tomasflobbe]
* Using the methods added in SOLR-10833 to parse the values 
* handling inc operation on other fields
* return solrException instead of NPE when user passes null
* Currently, for some operation field name is not available during hence, error message doesn't contain field name. One way to include field name is to wrap

{code:java}
https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java#L101
{code}
in try-catch  block, let me know if this makes sense or just error with value is enough


> in-place updates currently throw NumberFormatException instead of a Bad Request SolrException for bad input
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-10860
>                 URL: https://issues.apache.org/jira/browse/SOLR-10860
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Ishan Chattopadhyaya
>            Priority: Major
>         Attachments: SOLR-10860.patch, SOLR-10860.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org