You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Andrew.D.lin (Jira)" <ji...@apache.org> on 2020/01/14 02:57:00 UTC
[jira] [Comment Edited] (FLINK-15307) Subclasses of
FailoverStrategy are easily confused with implementation classes of
RestartStrategy
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014810#comment-17014810 ]
Andrew.D.lin edited comment on FLINK-15307 at 1/14/20 2:56 AM:
---------------------------------------------------------------
Hi [~zhuzh], I modified it according to your suggestion, only modified strategy under flip1.
hope you help review and give me some suggestions. thank you very much! :D
was (Author: andrew_lin):
[~zhuzh] sorry, I missed it, Let me modify it
> Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-15307
> URL: https://issues.apache.org/jira/browse/FLINK-15307
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Configuration
> Reporter: Andrew.D.lin
> Assignee: Andrew.D.lin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2019-12-18-14-59-03-181.png
>
> Time Spent: 10m
> Remaining Estimate: 24h
>
> Subclasses of RestartStrategy
> * FailingRestartStrategy
> * FailureRateRestartStrategy
> * FixedDelayRestartStrategy
> * InfiniteDelayRestartStrategy
> Implementation class of FailoverStrategy
> * AdaptedRestartPipelinedRegionStrategyNG
> * RestartAllStrategy
> * RestartIndividualStrategy
> * RestartPipelinedRegionStrategy
>
> FailoverStrategy describes how the job computation recovers from task failures.
> I think the following names may be easier to understand and easier to distinguish:
> Implementation class of FailoverStrategy
> * AdaptedPipelinedRegionFailoverStrategyNG
> * FailoverAllStrategy
> * FailoverIndividualStrategy
> * FailoverPipelinedRegionStrategy
> FailoverStrategy is currently generated by configuration. If we change the name of the implementation class, it will not affect compatibility.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)