[GitHub] [cxf] reta commented on a diff in pull request #979: [CXF-8749]:Existing handler file fails the compile generated java sou…

[GitBox <gi...@apache.org>]

reta commented on code in PR #979:
URL: https://github.com/apache/cxf/pull/979#discussion_r943625080


##########
tools/common/src/main/java/org/apache/cxf/tools/common/ClassUtils.java:
##########
@@ -97,8 +99,9 @@ public void compile(ToolContext context) throws ToolException {
 
                                 try {
                                     Files.copy(otherFile,
-                                        Files.createDirectories(Paths.get(targetDir, dirName)).resolve(str));
-
+                                            Files.createDirectories(Paths.get(targetDir, dirName)).resolve(str));
+                                } catch (FileAlreadyExistsException existsException) {
+                                    LOG.log(Level.WARNING, "EXIST_RESOURCE_FILE", otherFile);

Review Comment:
   @jimma seems the message is not referring to the correct file: `otherFile` is a source and should exist. The target is `Files.createDirectories(Paths.get(targetDir, dirName)).resolve(str)` (probably needs a new variable)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org