[GitHub] [netbeans] lkishalmi commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3

[GitBox <gi...@apache.org>]

lkishalmi commented on a change in pull request #2065: [NETBEANS-4118] Moved Gradle Tooling into its own module and to version 6.3
URL: https://github.com/apache/netbeans/pull/2065#discussion_r405282481
 
 

 ##########
 File path: groovy/libs.gradle/nbproject/project.properties
 ##########
 @@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+is.autoload=true
+nbm.needs.restart=true
+
+javac.source=1.8
+javac.compilerargs=-Xlint -Xlint:-serial
+
+# For more information, please see http://wiki.netbeans.org/SignatureTest
+sigtest.gen.fail.on.error=false
 
 Review comment:
   Well, I stole that line from the libs.groovy module. As these Gradle Tooling update happens in a controlled way the dependent modules are checked as well.
   What should be the procedure if I leave this one true and the sigtest fails? I would not like to bump the release-version of this module in that case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists