[GitHub] [zookeeper] eolivelli commented on issue #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2

[GitBox <gi...@apache.org>]

eolivelli commented on issue #1238: ZOOKEEPER-3695: Source release tarball does not match repository in 3.6.0 - part2
URL: https://github.com/apache/zookeeper/pull/1238#issuecomment-580408419
 
 
   @anmolnar @nkalmar I need a little help merging this patch.
   Please cherry pick to branch-3.6 and release-3.6.0
   
   I saw that the source release tarball still does not reflect perfectly the repository
   
   in order to build the tarball the command is:
   `mvn clean install -DskipTests -Pfull-build -Papache-release`
   
   a shortcut is to add '-N' (non recursive) in order to build only the top level project
   `mvn clean install -DskipTests -Pfull-build -Papache-release -N`
   
   remember to issue a "git clean -xfd" in order to have a clean git repository
   
   I feel that zookeeper-server/src/main/resources/git.properties is in the wrong place, it is a generated resource and it should stay in zookeeper-server/target/generated-resources/git.properties or something like that.
   btw This patch does not address this issue, and the package is built correctly only if you start with a clean git repository 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services