You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/10 19:49:53 UTC
[GitHub] [incubator-superset] zuzana-vej opened a new issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
zuzana-vej opened a new issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004
Filter dropdown options are not visible, making it hard for user to make their filter selection.
### Expected results
The filter dropdown should display in a way that it's possible for user to scroll through the options.
### Actual results
The filter dropdown displays improperly making very hard for user to select their filter.
#### Screenshots
#### How to reproduce the bug
1. Go to Dashboard
2. Click on Filter box (this is specifically a time grain filter. From Dashboard layout perspective, this time grain filter is right above "Apply button" on filter box. Right below the filter box is "header" followed by charts.
3. When clicking to selecting time grain, See error it doesn't display properly
### Environment
(please complete the following information):
- superset version: `master`
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej edited a comment on issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
Posted by GitBox <gi...@apache.org>.
zuzana-vej edited a comment on issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004#issuecomment-744901758
Here is a recording. I would expect the TIME GRAIN box behave same as the other dropdowns - see the difference on the video.
Otherwise this happens when user resizes the filter box to a small size. The larger the size, the more dropdown option they see - specifically for TIME GRAIN. If the filter box has only TIME GRAIN and they resize it, they face the issue initially described. If the filter box has 10 other filters, or if they keep it large (height) they might not face this issue at all. Most users try to conserve space and make filter boxes as small as possible.
As you see on the video, this issue doesn't occur for other filter dropdowns - like here it doesn't happen for "office" dropdown. It would be great if the drop downs behave in a same way (otherwise user might think it's a bug).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004#issuecomment-742785606
@adam-stasiak let's add this to our test case.
@zuzana-vej thanks for reporting!
im not able to reproduce from latest master, can you attach a gif?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004#issuecomment-742785606
@adam-stasiak let's add this to our test case.
@zuzana-vej thanks for reporting!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004#issuecomment-743371356
@zuzana-vej btw, we recently fixed the filter box, it's scrollable when the size is small. have you tried it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004#issuecomment-744901758
Here is a recording. I would expect the TIME GRAIN box behave same as the other dropdowns - see the difference on the video.
Otherwise this happens when user resizes the filter box to a small size. The larger the size, the more dropdown option they see - specifically for TIME GRAIN. If the filter box has only TIME GRAIN and they resize it, they face the issue initially described. If the filter box has 10 other filters, or if they keep it large (height) they might not face this issue at all. Most users try to conserve space and make filter boxes as small as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej edited a comment on issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
Posted by GitBox <gi...@apache.org>.
zuzana-vej edited a comment on issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004#issuecomment-747819468
Just wanted to confirm this is still the issue and we are 100% up to date with mater now -- see the gif in above listed comment. it only happens for time grain, and when you don't have many other filter boxes below.
(@junlincc can someone working on filters from your side check? it's a **low priority**, since it's just a cosmetic issue, but we are able to reproduce it pretty consistently)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004#issuecomment-747819468
Just wanted to confirm this is still the issue and we are 100% up to date with mater now -- see the gif in above listed comment. it only happens for time grain, and when you don't have many other filter boxes below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej edited a comment on issue #12004: Cosmetic: Filter dropdown options on time grain filter not visible
Posted by GitBox <gi...@apache.org>.
zuzana-vej edited a comment on issue #12004:
URL: https://github.com/apache/incubator-superset/issues/12004#issuecomment-744901758
Here is a recording. I would expect the TIME GRAIN box behave same as the other dropdowns - see the difference on the video.
Otherwise this happens when user resizes the filter box to a small size. The larger the size, the more dropdown option they see - specifically for TIME GRAIN. If the filter box has only TIME GRAIN and they resize it, they face the issue initially described. If the filter box has 10 other filters, or if they keep it large (height) they might not face this issue at all. Most users try to conserve space and make filter boxes as small as possible.
As you see on the video, this issue doesn't occur for other filter dropdowns - like here it doesn't happen for "office" dropdown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org