You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "robertmu (via GitHub)" <gi...@apache.org> on 2025/08/27 07:09:02 UTC

[PR] fix(test): Adapt base type creation test for Cloudberry [cloudberry-gpbackup]

robertmu opened a new pull request, #30:
URL: https://github.com/apache/cloudberry-gpbackup/pull/30

   This commit resolves an integration test failure for PrintCreateBaseTypeStatement when running against Cloudberry, which is based on PostgreSQL 14.
   
   PostgreSQL 14 enforces stricter validation for `CREATE TYPE`. It now requires that a type specified with an `ELEMENT` parameter must also have an associated subscripting function. This requirement is not enforced in PostgreSQL 12 (on which GPDB 7 is based), which allowed `ELEMENT` as a metadata-only attribute.
   
   To ensure compatibility, this change conditionally modifies the `baseType` struct in the `BeforeEach` block. When running on Cloudberry, the `Element` field is set to an empty string. This ensures that the auto-generated `CREATE TYPE` statement is valid for PostgreSQL 14, allowing the test to pass while preserving the original logic for GPDB 7.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] fix(test): Adapt base type creation test for Cloudberry [cloudberry-gpbackup]

Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 merged PR #30:
URL: https://github.com/apache/cloudberry-gpbackup/pull/30


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org