You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Lily Chen <li...@mesosphere.io> on 2015/08/08 03:35:59 UTC
Review Request 37245: Refactor Docker Image to exclude path and
manifest.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Bugs: MESOS-2850
https://issues.apache.org/jira/browse/MESOS-2850
Repository: mesos
Description
-------
Refactor Docker Image to exclude path and manifest.
Diffs
-----
src/slave/containerizer/provisioners/docker.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker.cpp PRE-CREATION
src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37245/diff/
Testing
-------
make check
Thanks,
Lily Chen
Re: Review Request 37245: Refactor Docker Image to exclude path and
manifest.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/
-----------------------------------------------------------
(Updated Aug. 16, 2015, 8:33 a.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-2850
https://issues.apache.org/jira/browse/MESOS-2850
Repository: mesos
Description
-------
Refactor Docker Image to exclude path and manifest.
Diffs (updated)
-----
src/slave/containerizer/provisioners/docker.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker.cpp PRE-CREATION
src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37245/diff/
Testing
-------
make check
Thanks,
Lily Chen
Re: Review Request 37245: Refactor Docker Image to exclude path and
manifest.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/
-----------------------------------------------------------
(Updated Aug. 15, 2015, 12:41 a.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-2850
https://issues.apache.org/jira/browse/MESOS-2850
Repository: mesos
Description
-------
Refactor Docker Image to exclude path and manifest.
Diffs (updated)
-----
src/slave/containerizer/provisioners/docker.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker.cpp PRE-CREATION
src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37245/diff/
Testing
-------
make check
Thanks,
Lily Chen
Re: Review Request 37245: Refactor Docker Image to exclude path and
manifest.
Posted by Lily Chen <li...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 11:29 p.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-2850
https://issues.apache.org/jira/browse/MESOS-2850
Repository: mesos
Description
-------
Refactor Docker Image to exclude path and manifest.
Diffs (updated)
-----
src/slave/containerizer/provisioners/docker.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker.cpp PRE-CREATION
src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37245/diff/
Testing
-------
make check
Thanks,
Lily Chen
Re: Review Request 37245: Refactor Docker Image to exclude path and
manifest.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/#review94647
-----------------------------------------------------------
src/slave/containerizer/provisioners/docker.hpp (line 70)
<https://reviews.apache.org/r/37245/#comment149254>
Two more spaces to the right
src/slave/containerizer/provisioners/docker.cpp (line 200)
<https://reviews.apache.org/r/37245/#comment149255>
Can you fix this in the earlier commit where this is introduced?
- Timothy Chen
On Aug. 8, 2015, 1:35 a.m., Lily Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37245/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2015, 1:35 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-2850
> https://issues.apache.org/jira/browse/MESOS-2850
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactor Docker Image to exclude path and manifest.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioners/docker.hpp PRE-CREATION
> src/slave/containerizer/provisioners/docker.cpp PRE-CREATION
> src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION
> src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37245/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Lily Chen
>
>