You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/12 20:49:18 UTC
[GitHub] [druid] a2l007 opened a new pull request, #13078: Initialize NullValueHandlingConfig for failed tests
a2l007 opened a new pull request, #13078:
URL: https://github.com/apache/druid/pull/13078
When run independently, tests `DelegateOrMinKeyCollectorTest` and `QuantilesSketchKeyCollectorTest` currently fail with the following error:
```
[ERROR] Errors:
[ERROR] org.apache.druid.msq.statistics.DelegateOrMinKeyCollectorTest.testAdd
[ERROR] Run 1: DelegateOrMinKeyCollectorTest.testAdd:81->createKey:148 » IllegalState NullHandling module not initialized, call NullHandling.initializeForTests()
[ERROR] org.apache.druid.msq.statistics.DelegateOrMinKeyCollectorTest.testDownSampleSingleKey
[ERROR] Run 1: DelegateOrMinKeyCollectorTest.testDownSampleSingleKey:99->createKey:148 » IllegalState NullHandling module not initialized, call NullHandling.initializeForTests()
[ERROR] org.apache.druid.msq.statistics.DelegateOrMinKeyCollectorTest.testDownSampleTwoKeys
[ERROR] Run 1: DelegateOrMinKeyCollectorTest.testDownSampleTwoKeys:125->createKey:148 » IllegalState NullHandling module not initialized, call NullHandling.initializeForTests()
[ERROR] org.apache.druid.msq.statistics.QuantilesSketchKeyCollectorTest.test_sequentialKeys_unweighted
[ERROR] Run 1: QuantilesSketchKeyCollectorTest.test_sequentialKeys_unweighted:66 » IllegalState NullHandling module not initialized, call NullHandling.initializeForTests()
[ERROR] org.apache.druid.msq.statistics.QuantilesSketchKeyCollectorTest.test_uniformRandomKeys_barbellWeighted
[ERROR] Run 1: QuantilesSketchKeyCollectorTest.test_uniformRandomKeys_barbellWeighted:136 » IllegalState NullHandling module not initialized, call NullHandling.initializeForTests()
[ERROR] org.apache.druid.msq.statistics.QuantilesSketchKeyCollectorTest.test_uniformRandomKeys_inverseBarbellWeighted
[ERROR] Run 1: QuantilesSketchKeyCollectorTest.test_uniformRandomKeys_inverseBarbellWeighted:163 » IllegalState NullHandling module not initialized, call NullHandling.initializeForTests()
[ERROR] Run 1: QuantilesSketchKeyCollectorTest.test_uniformRandomKeys_unweighted:85 » IllegalState NullHandling module not initialized, call NullHandling.initializeForTests()
ERROR] org.apache.druid.msq.statistics.QuantilesSketchKeyCollectorTest.test_uniformRandomKeys_unweighted_downSampledToSmallestSize
[ERROR] Run 1: QuantilesSketchKeyCollectorTest.test_uniformRandomKeys_unweighted_downSampledToSmallestSize:103 » IllegalState NullHandling module not initialized, call NullHandling.initializeForTests()
```
This PR initializes the NullValueHandlingConfig to fix these tests.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on pull request #13078: Initialize NullValueHandlingConfig for failed tests
Posted by GitBox <gi...@apache.org>.
kfaraz commented on PR #13078:
URL: https://github.com/apache/druid/pull/13078#issuecomment-1246372334
@a2l007 , you might need to merge the latest master to fix these failures using #13083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 merged pull request #13078: Initialize NullValueHandlingConfig for failed tests
Posted by GitBox <gi...@apache.org>.
FrankChen021 merged PR #13078:
URL: https://github.com/apache/druid/pull/13078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] a2l007 commented on pull request #13078: Initialize NullValueHandlingConfig for failed tests
Posted by GitBox <gi...@apache.org>.
a2l007 commented on PR #13078:
URL: https://github.com/apache/druid/pull/13078#issuecomment-1245607571
@kfaraz Thanks for the review. Refactored the tests based on your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org