You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "sorphi (JIRA)" <ta...@jakarta.apache.org> on 2006/06/12 05:26:30 UTC

[jira] Created: (TAPESTRY-988) Function mismatch with description in document: Form.jwc and tapestry.request.xml

Function mismatch with description in document:  Form.jwc and tapestry.request.xml
----------------------------------------------------------------------------------

         Key: TAPESTRY-988
         URL: http://issues.apache.org/jira/browse/TAPESTRY-988
     Project: Tapestry
        Type: Bug

  Components: Framework  
    Versions: 4.0.1    
 Environment: hivemind1.1.1
    Reporter: sorphi
    Priority: Minor


1/ Form component specifiaction

     <parameter name="clientValidationEnabled">
    <description>
    If true (the default) then client-side validation will be generated upon render for any
        required or validating fields.
	</description>
  </parameter>

Shoud declare a default value as description elment said. Or else, the value of clientValidationEnabled property in enhanced Form class will be false. 

<parameter name="clientValidationEnabled"  default-value="ognl:true"> 




2/CookieSource hivemind configuration:

<service-point id="CookieSource">
    
    Allows access to incoming HTTP cookie values for the active (per-thread) request.
    
    <invoke-factory>
      <construct class="impl.CookieSourceImpl">
        <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
        <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
        <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
      </construct>
    </invoke-factory>    
  </service-point>  


<set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>

Here, defaultMaxAge value is injected by propertyname placeHolder, it will not prefer to search value from application specification meta elment - "org.apache.tapestry.default-cookie-max-age". (I test it twice.)

But this document say that specialize meta in app spec will be useful. Or I misunderstand? 

http://jakarta.apache.org/tapestry/UsersGuide/configuration.html#configuration.properties

I think "app-property:org.apache.tapestry.default-cookie-max-age"  will be ok. Like this:

  <implementation service-id="tapestry.request.CookieSource">
    <invoke-factory>
      <construct class="framework.tapestry.service.CookieSourceImpl">
        <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
        <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
        <set-object property="defaultMaxAge" value="app-property:org.apache.tapestry.default-cookie-max-age"/>
        <set-object property="domain" value="app-property:framework.tapestry.default-cookie-domain"/>
        <set-object property="path" value="app-property:framework.tapestry.default-cookie-path"/>
        <set-object property="version" value="app-property:framework.tapestry.default-cookie-version"/>
      </construct>
    </invoke-factory>
  </implementation>

But must define my own implements.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-988) Function mismatch with description in document: Form.jwc and tapestry.request.xml

Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469729 ] 

Andreas Andreou commented on TAPESTRY-988:
------------------------------------------

Regarding org.apache.tapestry.default-cookie-max-age, I guess it needs to be specified as a JVM system property.

Since CookieSource allows setting per-cookie max ages, i don't feel this is important any more - but the docs should be updated.

> Function mismatch with description in document:  Form.jwc and tapestry.request.xml
> ----------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-988
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-988
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.0.1
>         Environment: hivemind1.1.1
>            Reporter: sorphi
>         Assigned To: Andreas Andreou
>            Priority: Minor
>             Fix For: 4.1.2
>
>
> 1/ Form component specifiaction
>      <parameter name="clientValidationEnabled">
>     <description>
>     If true (the default) then client-side validation will be generated upon render for any
>         required or validating fields.
> 	</description>
>   </parameter>
> Shoud declare a default value as description elment said. Or else, the value of clientValidationEnabled property in enhanced Form class will be false. 
> <parameter name="clientValidationEnabled"  default-value="ognl:true"> 
> 2/CookieSource hivemind configuration:
> <service-point id="CookieSource">
>     
>     Allows access to incoming HTTP cookie values for the active (per-thread) request.
>     
>     <invoke-factory>
>       <construct class="impl.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
>       </construct>
>     </invoke-factory>    
>   </service-point>  
> <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
> Here, defaultMaxAge value is injected by propertyname placeHolder, it will not prefer to search value from application specification meta elment - "org.apache.tapestry.default-cookie-max-age". (I test it twice.)
> But this document say that specialize meta in app spec will be useful. Or I misunderstand? 
> http://jakarta.apache.org/tapestry/UsersGuide/configuration.html#configuration.properties
> I think "app-property:org.apache.tapestry.default-cookie-max-age"  will be ok. Like this:
>   <implementation service-id="tapestry.request.CookieSource">
>     <invoke-factory>
>       <construct class="framework.tapestry.service.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set-object property="defaultMaxAge" value="app-property:org.apache.tapestry.default-cookie-max-age"/>
>         <set-object property="domain" value="app-property:framework.tapestry.default-cookie-domain"/>
>         <set-object property="path" value="app-property:framework.tapestry.default-cookie-path"/>
>         <set-object property="version" value="app-property:framework.tapestry.default-cookie-version"/>
>       </construct>
>     </invoke-factory>
>   </implementation>
> But must define my own implements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-988) Function mismatch with description in document: Form.jwc and tapestry.request.xml

Posted by "Andreas Andreou (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Andreou updated TAPESTRY-988:
-------------------------------------

    Assignee:     (was: Andreas Andreou)

> Function mismatch with description in document:  Form.jwc and tapestry.request.xml
> ----------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-988
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-988
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.0.1
>         Environment: hivemind1.1.1
>            Reporter: sorphi
>            Priority: Minor
>             Fix For: 4.1.2
>
>
> 1/ Form component specifiaction
>      <parameter name="clientValidationEnabled">
>     <description>
>     If true (the default) then client-side validation will be generated upon render for any
>         required or validating fields.
> 	</description>
>   </parameter>
> Shoud declare a default value as description elment said. Or else, the value of clientValidationEnabled property in enhanced Form class will be false. 
> <parameter name="clientValidationEnabled"  default-value="ognl:true"> 
> 2/CookieSource hivemind configuration:
> <service-point id="CookieSource">
>     
>     Allows access to incoming HTTP cookie values for the active (per-thread) request.
>     
>     <invoke-factory>
>       <construct class="impl.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
>       </construct>
>     </invoke-factory>    
>   </service-point>  
> <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
> Here, defaultMaxAge value is injected by propertyname placeHolder, it will not prefer to search value from application specification meta elment - "org.apache.tapestry.default-cookie-max-age". (I test it twice.)
> But this document say that specialize meta in app spec will be useful. Or I misunderstand? 
> http://jakarta.apache.org/tapestry/UsersGuide/configuration.html#configuration.properties
> I think "app-property:org.apache.tapestry.default-cookie-max-age"  will be ok. Like this:
>   <implementation service-id="tapestry.request.CookieSource">
>     <invoke-factory>
>       <construct class="framework.tapestry.service.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set-object property="defaultMaxAge" value="app-property:org.apache.tapestry.default-cookie-max-age"/>
>         <set-object property="domain" value="app-property:framework.tapestry.default-cookie-domain"/>
>         <set-object property="path" value="app-property:framework.tapestry.default-cookie-path"/>
>         <set-object property="version" value="app-property:framework.tapestry.default-cookie-version"/>
>       </construct>
>     </invoke-factory>
>   </implementation>
> But must define my own implements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-988) Function mismatch with description in document: Form.jwc and tapestry.request.xml

Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-988?page=all ]

Jesse Kuhnert updated TAPESTRY-988:
-----------------------------------

    Fix Version/s: 4.1.2

> Function mismatch with description in document:  Form.jwc and tapestry.request.xml
> ----------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-988
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-988
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.0.1
>         Environment: hivemind1.1.1
>            Reporter: sorphi
>            Priority: Minor
>             Fix For: 4.1.2
>
>
> 1/ Form component specifiaction
>      <parameter name="clientValidationEnabled">
>     <description>
>     If true (the default) then client-side validation will be generated upon render for any
>         required or validating fields.
> 	</description>
>   </parameter>
> Shoud declare a default value as description elment said. Or else, the value of clientValidationEnabled property in enhanced Form class will be false. 
> <parameter name="clientValidationEnabled"  default-value="ognl:true"> 
> 2/CookieSource hivemind configuration:
> <service-point id="CookieSource">
>     
>     Allows access to incoming HTTP cookie values for the active (per-thread) request.
>     
>     <invoke-factory>
>       <construct class="impl.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
>       </construct>
>     </invoke-factory>    
>   </service-point>  
> <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
> Here, defaultMaxAge value is injected by propertyname placeHolder, it will not prefer to search value from application specification meta elment - "org.apache.tapestry.default-cookie-max-age". (I test it twice.)
> But this document say that specialize meta in app spec will be useful. Or I misunderstand? 
> http://jakarta.apache.org/tapestry/UsersGuide/configuration.html#configuration.properties
> I think "app-property:org.apache.tapestry.default-cookie-max-age"  will be ok. Like this:
>   <implementation service-id="tapestry.request.CookieSource">
>     <invoke-factory>
>       <construct class="framework.tapestry.service.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set-object property="defaultMaxAge" value="app-property:org.apache.tapestry.default-cookie-max-age"/>
>         <set-object property="domain" value="app-property:framework.tapestry.default-cookie-domain"/>
>         <set-object property="path" value="app-property:framework.tapestry.default-cookie-path"/>
>         <set-object property="version" value="app-property:framework.tapestry.default-cookie-version"/>
>       </construct>
>     </invoke-factory>
>   </implementation>
> But must define my own implements.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Resolved: (TAPESTRY-988) Function mismatch with description in document: Form.jwc and tapestry.request.xml

Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Kuhnert resolved TAPESTRY-988.
------------------------------------

    Resolution: Fixed
      Assignee: Jesse Kuhnert

Fixed the service configs and double checked to be sure the documentation is correct. (which it is now in 4.1.2 ) 

> Function mismatch with description in document:  Form.jwc and tapestry.request.xml
> ----------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-988
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-988
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.0.1
>         Environment: hivemind1.1.1
>            Reporter: sorphi
>            Assignee: Jesse Kuhnert
>            Priority: Minor
>             Fix For: 4.1.2
>
>
> 1/ Form component specifiaction
>      <parameter name="clientValidationEnabled">
>     <description>
>     If true (the default) then client-side validation will be generated upon render for any
>         required or validating fields.
> 	</description>
>   </parameter>
> Shoud declare a default value as description elment said. Or else, the value of clientValidationEnabled property in enhanced Form class will be false. 
> <parameter name="clientValidationEnabled"  default-value="ognl:true"> 
> 2/CookieSource hivemind configuration:
> <service-point id="CookieSource">
>     
>     Allows access to incoming HTTP cookie values for the active (per-thread) request.
>     
>     <invoke-factory>
>       <construct class="impl.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
>       </construct>
>     </invoke-factory>    
>   </service-point>  
> <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
> Here, defaultMaxAge value is injected by propertyname placeHolder, it will not prefer to search value from application specification meta elment - "org.apache.tapestry.default-cookie-max-age". (I test it twice.)
> But this document say that specialize meta in app spec will be useful. Or I misunderstand? 
> http://jakarta.apache.org/tapestry/UsersGuide/configuration.html#configuration.properties
> I think "app-property:org.apache.tapestry.default-cookie-max-age"  will be ok. Like this:
>   <implementation service-id="tapestry.request.CookieSource">
>     <invoke-factory>
>       <construct class="framework.tapestry.service.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set-object property="defaultMaxAge" value="app-property:org.apache.tapestry.default-cookie-max-age"/>
>         <set-object property="domain" value="app-property:framework.tapestry.default-cookie-domain"/>
>         <set-object property="path" value="app-property:framework.tapestry.default-cookie-path"/>
>         <set-object property="version" value="app-property:framework.tapestry.default-cookie-version"/>
>       </construct>
>     </invoke-factory>
>   </implementation>
> But must define my own implements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Assigned: (TAPESTRY-988) Function mismatch with description in document: Form.jwc and tapestry.request.xml

Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Andreou reassigned TAPESTRY-988:
----------------------------------------

    Assignee: Andreas Andreou

> Function mismatch with description in document:  Form.jwc and tapestry.request.xml
> ----------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-988
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-988
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.0.1
>         Environment: hivemind1.1.1
>            Reporter: sorphi
>         Assigned To: Andreas Andreou
>            Priority: Minor
>             Fix For: 4.1.2
>
>
> 1/ Form component specifiaction
>      <parameter name="clientValidationEnabled">
>     <description>
>     If true (the default) then client-side validation will be generated upon render for any
>         required or validating fields.
> 	</description>
>   </parameter>
> Shoud declare a default value as description elment said. Or else, the value of clientValidationEnabled property in enhanced Form class will be false. 
> <parameter name="clientValidationEnabled"  default-value="ognl:true"> 
> 2/CookieSource hivemind configuration:
> <service-point id="CookieSource">
>     
>     Allows access to incoming HTTP cookie values for the active (per-thread) request.
>     
>     <invoke-factory>
>       <construct class="impl.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
>       </construct>
>     </invoke-factory>    
>   </service-point>  
> <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
> Here, defaultMaxAge value is injected by propertyname placeHolder, it will not prefer to search value from application specification meta elment - "org.apache.tapestry.default-cookie-max-age". (I test it twice.)
> But this document say that specialize meta in app spec will be useful. Or I misunderstand? 
> http://jakarta.apache.org/tapestry/UsersGuide/configuration.html#configuration.properties
> I think "app-property:org.apache.tapestry.default-cookie-max-age"  will be ok. Like this:
>   <implementation service-id="tapestry.request.CookieSource">
>     <invoke-factory>
>       <construct class="framework.tapestry.service.CookieSourceImpl">
>         <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
>         <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
>         <set-object property="defaultMaxAge" value="app-property:org.apache.tapestry.default-cookie-max-age"/>
>         <set-object property="domain" value="app-property:framework.tapestry.default-cookie-domain"/>
>         <set-object property="path" value="app-property:framework.tapestry.default-cookie-path"/>
>         <set-object property="version" value="app-property:framework.tapestry.default-cookie-version"/>
>       </construct>
>     </invoke-factory>
>   </implementation>
> But must define my own implements.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org