You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2018/06/26 19:12:58 UTC
Review Request 67748: Added monitoring paragraph to
high-availability.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67748/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Joerg Schad.
Repository: mesos
Description
-------
Added monitoring paragraph to high-availability.md.
Diffs
-----
docs/high-availability.md f5d25e910763a85ddbb8c43d3dd5019c9a3b00af
Diff: https://reviews.apache.org/r/67748/diff/1/
Testing
-------
Rendered by github markdown renderer.
Thanks,
Till Toenshoff
Re: Review Request 67748: Added monitoring paragraph to
high-availability.md.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
> On June 26, 2018, 9:12 p.m., Joerg Schad wrote:
> > docs/high-availability.md
> > Lines 58 (patched)
> > <https://reviews.apache.org/r/67748/diff/1/?file=2045270#file2045270line58>
> >
> > Can we check what the exact defintion of this metric is? (connected to each other, connected to the leader, how much does it depend on the queried master). I unfortunately do not have the correct/best formulation here at hand, but I feel that this is a bit ambigious:
> >
> > @xujyan should know more here.
Let's have that as another improvement once we get a definite, correct answer on what exactly the "ensemble size" means. ok?
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67748/#review205395
-----------------------------------------------------------
On June 26, 2018, 7:12 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67748/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 7:12 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added monitoring paragraph to high-availability.md.
>
>
> Diffs
> -----
>
> docs/high-availability.md f5d25e910763a85ddbb8c43d3dd5019c9a3b00af
>
>
> Diff: https://reviews.apache.org/r/67748/diff/1/
>
>
> Testing
> -------
>
> Rendered by github markdown renderer.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 67748: Added monitoring paragraph to
high-availability.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67748/#review205395
-----------------------------------------------------------
Fix it, then Ship it!
Thanks Till, great addition. Only one comment regarding the exact defition of the ensemble size metric.
docs/high-availability.md
Lines 58 (patched)
<https://reviews.apache.org/r/67748/#comment288283>
Can we check what the exact defintion of this metric is? (connected to each other, connected to the leader, how much does it depend on the queried master). I unfortunately do not have the correct/best formulation here at hand, but I feel that this is a bit ambigious:
@xujyan should know more here.
- Joerg Schad
On June 26, 2018, 7:12 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67748/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 7:12 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added monitoring paragraph to high-availability.md.
>
>
> Diffs
> -----
>
> docs/high-availability.md f5d25e910763a85ddbb8c43d3dd5019c9a3b00af
>
>
> Diff: https://reviews.apache.org/r/67748/diff/1/
>
>
> Testing
> -------
>
> Rendered by github markdown renderer.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 67748: Added monitoring paragraph to
high-availability.md.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67748/#review205394
-----------------------------------------------------------
PASS: Mesos patch 67748 was successfully built and tested.
Reviews applied: `['67748']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67748
- Mesos Reviewbot Windows
On June 26, 2018, 7:12 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67748/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 7:12 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added monitoring paragraph to high-availability.md.
>
>
> Diffs
> -----
>
> docs/high-availability.md f5d25e910763a85ddbb8c43d3dd5019c9a3b00af
>
>
> Diff: https://reviews.apache.org/r/67748/diff/1/
>
>
> Testing
> -------
>
> Rendered by github markdown renderer.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 67748: Added monitoring paragraph to
high-availability.md.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67748/#review205393
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67748]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 26, 2018, 7:12 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67748/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 7:12 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joerg Schad.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added monitoring paragraph to high-availability.md.
>
>
> Diffs
> -----
>
> docs/high-availability.md f5d25e910763a85ddbb8c43d3dd5019c9a3b00af
>
>
> Diff: https://reviews.apache.org/r/67748/diff/1/
>
>
> Testing
> -------
>
> Rendered by github markdown renderer.
>
>
> Thanks,
>
> Till Toenshoff
>
>