[GitHub] [incubator-superset] villebro commented on a change in pull request #8457: [fix] Improve csv upload functionality

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8457: [fix] Improve csv upload functionality
URL: https://github.com/apache/incubator-superset/pull/8457#discussion_r342788676
 
 

 ##########
 File path: superset/db_engine_specs/hive.py
 ##########
 @@ -98,7 +98,7 @@ def fetch_data(cls, cursor, limit: int) -> List[Tuple]:
             return []
 
     @classmethod
-    def create_table_from_csv(cls, form, table):  # pylint: disable=too-many-locals
+    def create_table_from_csv(cls, form):  # pylint: disable=too-many-locals
 
 Review comment:
   Based on my understanding of the `HiveEngineSpec.create_table_from_csv`, this actually aligns the functionality with that of `BaseEngineSpec`, as previously the Hive spec didn't create any metadata for new tables (all the others did). After this change metadata creation takes place outside of the engine spec, and works similarly for all engines, i.e. metadata is created in `database/views.py`, and only uploading of actual data is handled by the engine specs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org