[GitHub] [pulsar] murong00 commented on a change in pull request #4555: [Issue 4422] Support pulsar scripts to work with bookkeeper

[GitBox <gi...@apache.org>]

murong00 commented on a change in pull request #4555: [Issue 4422] Support pulsar scripts to work with bookkeeper
URL: https://github.com/apache/pulsar/pull/4555#discussion_r294669631
 
 

 ##########
 File path: conf/pulsar_env.sh
 ##########
 @@ -58,3 +58,16 @@ PULSAR_EXTRA_OPTS=${PULSAR_EXTRA_OPTS:-" -Dpulsar.allocator.exit_on_oom=true -Di
 
 #Wait time before forcefully kill the pulser server instance, if the stop is not successful
 #PULSAR_STOP_TIMEOUT=
+
+# Set BOOKIE options here to ensure that all pulsar scripts can work seamless with bookkeeper
+
+# default settings for starting bookkeeper
+
+# Memory size options
+BOOKIE_MEM=" -Xms2g -Xmx2g -XX:MaxDirectMemorySize=2g"
+
+# Garbage collection options
+BOOKIE_GC=" -XX:+UseG1GC -XX:MaxGCPauseMillis=10 -XX:+ParallelRefProcEnabled -XX:+UnlockExperimentalVMOptions -XX:+AggressiveOpts -XX:+DoEscapeAnalysis -XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 -XX:G1NewSizePercent=50 -XX:+DisableExplicitGC -XX:-ResizePLAB"
+
+# Extra options to be passed to the jvm
+BOOKIE_EXTRA_OPTS="${BOOKIE_EXTRA_OPTS} ${BOOKIE_MEM} ${BOOKIE_GC} -Dio.netty.leakDetectionLevel=disabled -Dio.netty.recycler.maxCapacity.default=1000 -Dio.netty.recycler.linkCapacity=1024"
 
 Review comment:
   @sijie Yeah, I also found the jvm settings are the same and can be reused. Already changed, PTAL.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services