[GitHub] jai1 commented on a change in pull request #1246: Separating configuration for client and server trust store

[GitBox <gi...@apache.org>]

jai1 commented on a change in pull request #1246:  Separating configuration for client and server trust store
URL: https://github.com/apache/incubator-pulsar/pull/1246#discussion_r168986187
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 ##########
 @@ -894,6 +896,14 @@ public void setBrokerClientAuthenticationParameters(String brokerClientAuthentic
         this.brokerClientAuthenticationParameters = brokerClientAuthenticationParameters;
     }
 
+    public String getBrokerClientTrustCertsFilePath() {
 
 Review comment:
   I feel it will make setting the trust store a bit complicated. Right now it is simple to set one trust store for client side and one for server.
   But if you feel strongly about it - let me know I will set the default to server trust store.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services