[GitHub] [apisix] spacewander commented on a diff in pull request #6908: fix: upstream nodes cant't include ipv6 addr

[GitBox <gi...@apache.org>]

spacewander commented on code in PR #6908:
URL: https://github.com/apache/apisix/pull/6908#discussion_r855824886


##########
t/APISIX.pm:
##########
@@ -200,7 +200,7 @@ if ($version =~ m/\/apisix-nginx-module/) {
     $a6_ngx_directives = <<_EOC_;
     apisix_delay_client_max_body_check on;
     apisix_mirror_on_demand on;
-    wasm_vm wasmtime;
+    #wasm_vm wasmtime;

Review Comment:
   Why remove that?



##########
apisix/schema_def.lua:
##########
@@ -37,7 +37,7 @@ local id_schema = {
     }
 }
 
-local host_def_pat = "^\\*?[0-9a-zA-Z-._]+$"
+local host_def_pat = "^\\*?[0-9a-zA-Z-._\\[\\]:]+$"

Review Comment:
   I would prefer to a simple regex check as a complex check is error-prone (may reject valid input)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org