You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/06/15 20:35:43 UTC

[GitHub] [couchdb] jiahuili430 commented on a change in pull request #3609: Normalize some config options

jiahuili430 commented on a change in pull request #3609:
URL: https://github.com/apache/couchdb/pull/3609#discussion_r652130254



##########
File path: src/couch/src/couch_httpd.erl
##########
@@ -110,7 +110,7 @@ start_link(Name, Options) ->
     {ok, ServerOptions} = couch_util:parse_term(
         config:get("httpd", "server_options", "[]")),
     {ok, SocketOptions} = couch_util:parse_term(
-        config:get("httpd", "socket_options", "[]")),
+        config:get("httpd", "socket_options", "[{sndbuf, 262144}]")),

Review comment:
       In default.ini, ServerOptions was commented out before, so it should get `[]`;
   However, `socket_options = [{sndbuf, 262144}]`, so I changed it here.
   Thanks for the review. @nickva 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org