You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@mail.utexas.edu> on 2008/08/16 04:11:59 UTC
Re: svn commit: r32500 - trunk/notes
gstein@tigris.org wrote:
> Author: gstein
> Date: Fri Aug 15 20:51:54 2008
> New Revision: 32500
>
> Log:
> short note about code organization so far
>
> Modified:
> trunk/notes/wc-ng-design
>
> Modified: trunk/notes/wc-ng-design
> URL: http://svn.collab.net/viewvc/svn/trunk/notes/wc-ng-design?pathrev=32500&r1=32499&r2=32500
> ==============================================================================
> --- trunk/notes/wc-ng-design Fri Aug 15 16:44:10 2008 (r32499)
> +++ trunk/notes/wc-ng-design Fri Aug 15 20:51:54 2008 (r32500)
> @@ -746,6 +746,18 @@ Note that 'children' applies only to kin
> the "empty file"
>
>
> +Code Organization
> +-----------------
> +
> +include/private/svn_wc_db.h (symbols: svn_wc__db_*)
Not to nit pick here, but would this be better structured as libsvn_wc/wc_db.h,
similar to the various layers in the filesystem code? Using include/private has
always felt a little icky to me, and I'd like to avoid it if possible. If these
APIs don't need to be used outside of libsvn_wc, we should try and keep them
internal.
> + Storage subsystem for the WC metadata/base-text information.
> + This is a private API, and the rest of the WC will be rebuilt
> + on top of this.
> +
> + This code deals with storage, and transactional modifications
> + of the data.
> +
> +
> Other sections
> ==============
> remain to be done
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>
Re: svn commit: r32500 - trunk/notes
Posted by Greg Stein <gs...@gmail.com>.
Oooh! Yeah. Good point. I don't need to share this interface between
libraries, so include/private is bunk.
Will tweak and develop as wc_db.h
Thanks,
-g
On Fri, Aug 15, 2008 at 9:11 PM, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> gstein@tigris.org wrote:
>>
>> Author: gstein
>> Date: Fri Aug 15 20:51:54 2008
>> New Revision: 32500
>>
>> Log:
>> short note about code organization so far
>>
>> Modified:
>> trunk/notes/wc-ng-design
>>
>> Modified: trunk/notes/wc-ng-design
>> URL:
>> http://svn.collab.net/viewvc/svn/trunk/notes/wc-ng-design?pathrev=32500&r1=32499&r2=32500
>>
>> ==============================================================================
>> --- trunk/notes/wc-ng-design Fri Aug 15 16:44:10 2008 (r32499)
>> +++ trunk/notes/wc-ng-design Fri Aug 15 20:51:54 2008 (r32500)
>> @@ -746,6 +746,18 @@ Note that 'children' applies only to kin
>> the "empty file"
>> +Code Organization
>> +-----------------
>> +
>> +include/private/svn_wc_db.h (symbols: svn_wc__db_*)
>
> Not to nit pick here, but would this be better structured as
> libsvn_wc/wc_db.h, similar to the various layers in the filesystem code?
> Using include/private has always felt a little icky to me, and I'd like to
> avoid it if possible. If these APIs don't need to be used outside of
> libsvn_wc, we should try and keep them internal.
>
>> + Storage subsystem for the WC metadata/base-text information.
>> + This is a private API, and the rest of the WC will be rebuilt
>> + on top of this.
>> + + This code deals with storage, and transactional
>> modifications
>> + of the data.
>> +
>> +
>> Other sections
>> ==============
>> remain to be done
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
>> For additional commands, e-mail: svn-help@subversion.tigris.org
>>
>>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org