You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by he...@apache.org on 2005/10/01 13:09:41 UTC
svn commit: r292953 -
/jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/PrintExceptions.java
Author: henning
Date: Sat Oct 1 04:09:37 2005
New Revision: 292953
URL: http://svn.apache.org/viewcvs?rev=292953&view=rev
Log:
We can actually do even a bit better by turning the
PrintWriter/StringWriter combo around. Funny how hard it is to get
that small piece of code really right...
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/PrintExceptions.java
Modified: jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/PrintExceptions.java
URL: http://svn.apache.org/viewcvs/jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/PrintExceptions.java?rev=292953&r1=292952&r2=292953&view=diff
==============================================================================
--- jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/PrintExceptions.java (original)
+++ jakarta/velocity/core/trunk/src/java/org/apache/velocity/app/event/implement/PrintExceptions.java Sat Oct 1 04:09:37 2005
@@ -87,26 +87,20 @@
private static String getStackTrace(Throwable throwable)
{
- StringWriter stackTraceWriter = null;
+ PrintWriter printWriter = null;
try
{
- stackTraceWriter = new StringWriter();
- throwable.printStackTrace(new PrintWriter(stackTraceWriter));
- stackTraceWriter.flush();
+ StringWriter stackTraceWriter = new StringWriter();
+ printWriter = new PrintWriter(stackTraceWriter);
+ throwable.printStackTrace(printWriter);
+ printWriter.flush();
return stackTraceWriter.toString();
}
finally
{
- if (stackTraceWriter != null)
+ if (printWriter != null)
{
- try
- {
- stackTraceWriter.close();
- }
- catch (IOException ioe)
- {
- // do nothing
- }
+ printWriter.close();
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org