You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by "Dies Koper (JIRA)" <ji...@apache.org> on 2012/08/31 11:20:07 UTC
[jira] [Created] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Dies Koper created DTACLOUD-310:
-----------------------------------
Summary: FGCP: support FW rule action and log rule
Key: DTACLOUD-310
URL: https://issues.apache.org/jira/browse/DTACLOUD-310
Project: DeltaCloud
Issue Type: New Feature
Components: Server
Environment: FGCP driver
Reporter: Dies Koper
Priority: Minor
In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marios Andreou resolved DTACLOUD-310.
-------------------------------------
Resolution: Fixed
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Assignee: Dies Koper
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DTACLOUD-310) FGCP: support FW rule action and log
rule
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marios Andreou closed DTACLOUD-310.
-----------------------------------
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Assignee: Dies Koper
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marios Andreou updated DTACLOUD-310:
------------------------------------
Attachment: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch
Dies, I reworked the initial patches to remove the "features" as we discussed on the dev@deltacloud.apache.org mailing list. I attach the reworked patch here for completeness/reference. This patch simply adds the rule_action and log_rule attributes to the FirewallRule action. I'll leave them on list for a day, push them and update this ticket. Then I'll ack your patches here and push them ontop,
thanks, marios
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marios Andreou reassigned DTACLOUD-310:
---------------------------------------
Assignee: Marios Andreou
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Assignee: Marios Andreou
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Dies Koper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dies Koper updated DTACLOUD-310:
--------------------------------
Attachment: 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
updated patch
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Assignee: Dies Koper
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447168#comment-13447168 ]
Marios Andreou commented on DTACLOUD-310:
-----------------------------------------
Dies - I can't apply your patches, can you please rebase them and send again?
[marios@name deltacloud]$ applyPatch /home/marios/Documents/WORK/Patches/FGCP_Firewalls_Extend/0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
error: patch failed: server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb:953
error: server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb: patch does not apply
thanks
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Assignee: Marios Andreou
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447163#comment-13447163 ]
Marios Andreou commented on DTACLOUD-310:
-----------------------------------------
ok - the attached patch had a typo (forgot 'end' on firewall_rule.rb) - thanks to Michal for review on mailing list. The additions to firewall rule model are commited with hash: 8adbe982207b146a185d1b9e4826b6d4f299c84c
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Assignee: Marios Andreou
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marios Andreou reassigned DTACLOUD-310:
---------------------------------------
Assignee: Dies Koper (was: Marios Andreou)
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Assignee: Dies Koper
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447556#comment-13447556 ]
Marios Andreou commented on DTACLOUD-310:
-----------------------------------------
ACK - with fix for minor typo:
[marios@name deltacloud]$ ./server/bin/deltacloudd -i fgcp
Starting Deltacloud API :: fgcp :: http://localhost:3001/api
/home/marios/Documents/WORK/NewEclipsey/DCore/deltacloud_git_repo/deltacloud/server/lib/deltacloud/helpers/driver_helper.rb:52:in `require_relative': /home/marios/Documents/WORK/NewEclipsey/DCore/deltacloud_git_repo/deltacloud/server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb:1323: syntax error, unexpected keyword_not, expecting keyword_do or '{' or '(' (SyntaxError)
on / does not exist. Specify one of / do
I put a new patch ontop of yours in order to keep the authorship info (if I had edited your patch it would have made me author).
Committed with hash: 755d46ef47f585d12a930fd3bb7bbe1f124e53f0 (FGCP: add rule action deny accept and log rule) and 5af7993713c8f467820de4a07eb496a400e13c37 (Fix typo in fgcp driver (related to patch on DTACLOUD_310)
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Assignee: Dies Koper
> Priority: Minor
> Attachments: 0001-Adds-log_rule-and-rule_action-for-FirewallRule-model.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch, 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DTACLOUD-310) FGCP: support FW rule action and
log rule
Posted by "Dies Koper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dies Koper updated DTACLOUD-310:
--------------------------------
Attachment: 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
Depends on Marios' patch that add attributes "rule_action" and "log_rule" on the FirewallRule object.
> FGCP: support FW rule action and log rule
> -----------------------------------------
>
> Key: DTACLOUD-310
> URL: https://issues.apache.org/jira/browse/DTACLOUD-310
> Project: DeltaCloud
> Issue Type: New Feature
> Components: Server
> Environment: FGCP driver
> Reporter: Dies Koper
> Priority: Minor
> Attachments: 0001-FGCP-add-rule-action-deny-accept-and-log-rule.patch
>
>
> In the FGCP, FW rules have an action which define whether the FW should Accept or Drop packets that are triggered by the rule. It also offers the option of defining whether the even should be logged or not.
> Without DC support for the former, DC only lists the Accept rules, which gives an incorrect view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira