You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/09 03:13:37 UTC

[GitHub] [arrow-datafusion] mingmwang commented on a diff in pull request #4839: Orthogonalize distribution and sort enforcement rules into `EnforceDistribution` and `EnforceSorting`

mingmwang commented on code in PR #4839:
URL: https://github.com/apache/arrow-datafusion/pull/4839#discussion_r1064259046


##########
datafusion/core/src/physical_optimizer/dist_enforcement.rs:
##########
@@ -832,7 +828,7 @@ fn new_join_conditions(
 /// Within this function, it checks whether we need to add additional plan operators
 /// of data exchanging and data ordering to satisfy the required distribution and ordering.
 /// And we should avoid to manually add plan operators of data exchanging and data ordering in other places

Review Comment:
   Please modify the comment here and remove the "data ordering".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org