[impala] 03/04: IMPALA-9008: Serialize Maven invocations to deflake impala-minimal-hive-exec

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 4c3f701204f92f8753cf65a97fe4804d1f77bc08
Author: Csaba Ringhofer <cs...@cloudera.com>
AuthorDate: Fri Oct 4 14:53:00 2019 +0200

    IMPALA-9008: Serialize Maven invocations to deflake impala-minimal-hive-exec
    
    Building impala-minimal-hive-exec was flaky (sometimes it failed
    to download Guava 14.0.1), and my guess is that it is related to
    downloading the same dependency in parallel with ext-data-source.
    
    Similarly to the solution in IMPALA-7051, I try to fix it by
    adding a fictional dependency (ext-data-source -> shaded-deps)
    to serialize the build.
    
    Full Maven dependency graph:
    fe -> yarn-extras -> ext-data-source -> shaded-deps -> impala-parent
    The ordering of yarn-extras, ext-data-source, and shaded-deps are
    arbitrary.
    
    Testing:
    - I never reproduced the original flakiness, so I just hope
      that it disappears with this change.
    
    Change-Id: Ic951ad7313e5ad9add2a00e6a442c6e97f235967
    Reviewed-on: http://gerrit.cloudera.org:8080/14372
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 ext-data-source/CMakeLists.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ext-data-source/CMakeLists.txt b/ext-data-source/CMakeLists.txt
index 2cd2b20..46e437c 100644
--- a/ext-data-source/CMakeLists.txt
+++ b/ext-data-source/CMakeLists.txt
@@ -15,6 +15,8 @@
 # specific language governing permissions and limitations
 # under the License.
 
-add_custom_target(ext-data-source ALL DEPENDS gen-deps impala-parent
+# The dependency on shaded-deps is only added to avoid parallel downloads
+# of dependencies. For more details see IMPALA-7051, which was a similar issue.
+add_custom_target(ext-data-source ALL DEPENDS gen-deps impala-parent shaded-deps
   COMMAND $ENV{IMPALA_HOME}/bin/mvn-quiet.sh -B install -DskipTests
 )