You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/09/09 08:35:34 UTC

Review Request 38208: RANGER-641 : Ranger kms start fails if java is not set and started using service keyword

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38208/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-641
    https://issues.apache.org/jira/browse/RANGER-641


Repository: ranger


Description
-------

Start ranger-kms using command "service ranger-kms start" (when Java is not installed) (after some seconds the ranger kms stops)
This happens when ranger-kms is started using service keyword.


Diffs
-----

  kms/scripts/ranger-kms 805ebcc 
  kms/scripts/setup.sh 2e7dd8e 

Diff: https://reviews.apache.org/r/38208/diff/


Testing
-------

Tested for manual install and and Restart of Ranger KMS.


Thanks,

Gautam Borad


Re: Review Request 38208: RANGER-641 : Ranger kms start fails if java is not set and started using service keyword

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38208/#review98621
-----------------------------------------------------------

Ship it!


Ship It!

- Velmurugan Periasamy


On Sept. 10, 2015, 4:57 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38208/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 4:57 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-641
>     https://issues.apache.org/jira/browse/RANGER-641
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Start ranger-kms using command "service ranger-kms start" (when Java is not set in PATH) after some seconds the ranger kms service stops.
> This happens when ranger-kms is started using service keyword.
> 
> 
> Diffs
> -----
> 
>   kms/scripts/ranger-kms 805ebcc 
>   kms/scripts/setup.sh 2e7dd8e 
> 
> Diff: https://reviews.apache.org/r/38208/diff/
> 
> 
> Testing
> -------
> 
> Tested for manual install and and Restart of Ranger KMS.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 38208: RANGER-641 : Ranger kms start fails if java is not set and started using service keyword

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38208/
-----------------------------------------------------------

(Updated Sept. 10, 2015, 4:57 a.m.)


Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Address review request comment and update the desc.


Bugs: RANGER-641
    https://issues.apache.org/jira/browse/RANGER-641


Repository: ranger


Description (updated)
-------

Start ranger-kms using command "service ranger-kms start" (when Java is not set in PATH) after some seconds the ranger kms service stops.
This happens when ranger-kms is started using service keyword.


Diffs
-----

  kms/scripts/ranger-kms 805ebcc 
  kms/scripts/setup.sh 2e7dd8e 

Diff: https://reviews.apache.org/r/38208/diff/


Testing
-------

Tested for manual install and and Restart of Ranger KMS.


Thanks,

Gautam Borad


Re: Review Request 38208: RANGER-641 : Ranger kms start fails if java is not set and started using service keyword

Posted by dilli dorai <di...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38208/#review98270
-----------------------------------------------------------



kms/scripts/ranger-kms (line 30)
<https://reviews.apache.org/r/38208/#comment154612>

    Comment not specific to this line.
    
    The description says "when Java is not installed". 
    Did yu mean when java is not in PATH?
    
    A correct description in Jira and code review would be helpful.


- dilli dorai


On Sept. 9, 2015, 6:35 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38208/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 6:35 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-641
>     https://issues.apache.org/jira/browse/RANGER-641
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Start ranger-kms using command "service ranger-kms start" (when Java is not installed) (after some seconds the ranger kms stops)
> This happens when ranger-kms is started using service keyword.
> 
> 
> Diffs
> -----
> 
>   kms/scripts/ranger-kms 805ebcc 
>   kms/scripts/setup.sh 2e7dd8e 
> 
> Diff: https://reviews.apache.org/r/38208/diff/
> 
> 
> Testing
> -------
> 
> Tested for manual install and and Restart of Ranger KMS.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>