You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/30 05:42:34 UTC

[GitHub] [flink] HuangXingBo opened a new pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

HuangXingBo opened a new pull request #14816:
URL: https://github.com/apache/flink/pull/14816


   ## What is the purpose of the change
   
   *This pull request will Introduce TimeWindow, CountWindow and corresponding coders.*
   
   
   ## Brief change log
   
     - *Add `TimeWindow` and `CountWindow`*
     - *Add coders and implementation of `TimeWindowCoder` and `CountWindowCoder`*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Add python coder test in `test_coders.py`*
     - *Add cython coder test in `test_fast_coders.py`*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694",
       "triggerID" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * daece76bc00e4dd9aab27b59c16fd67d57cc24d6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690) 
   * 8e01d37ab94d0b54c3e0fb1bc4d643036145042d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694",
       "triggerID" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e01d37ab94d0b54c3e0fb1bc4d643036145042d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694",
       "triggerID" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc222cffd760e24ee61008fc45575ae3fce78506",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13964",
       "triggerID" : "bc222cffd760e24ee61008fc45575ae3fce78506",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bc222cffd760e24ee61008fc45575ae3fce78506 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13964) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] WeiZhong94 commented on a change in pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on a change in pull request #14816:
URL: https://github.com/apache/flink/pull/14816#discussion_r584725808



##########
File path: flink-python/pyflink/fn_execution/window.py
##########
@@ -0,0 +1,126 @@
+################################################################################
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+import sys
+from abc import ABC, abstractmethod
+
+MAX_LONG_VALUE = sys.maxsize
+
+
+def long_to_int_with_bit_mixing(x: int) -> int:
+    x = (x ^ (x >> 30)) * 0xbf58476d1ce4e5b9
+    x = (x ^ (x >> 27)) * 0x94d049bb133111eb
+    x = x ^ (x >> 31)
+    return x
+
+
+def mod_inverse(x: int) -> int:
+    inverse = x * x * x
+    inverse *= 2 - x * inverse
+    inverse *= 2 - x * inverse
+    inverse *= 2 - x * inverse
+    return inverse
+
+
+class Window(ABC):
+    """
+    Window is a grouping of elements into finite buckets. Windows have a maximum timestamp
+    which means that, at some point, all elements that go into one window will have arrived.
+    """
+
+    @abstractmethod
+    def max_timestamp(self) -> int:
+        pass
+
+
+class TimeWindow(Window):
+    """
+    Window that represents a time interval from start (inclusive) to end (exclusive).
+    """
+
+    def __init__(self, start: int, end: int):
+        super(TimeWindow, self).__init__()
+        self.start = start
+        self.end = end
+
+    def max_timestamp(self) -> int:
+        return self.end - 1
+
+    def intersects(self, other: 'TimeWindow') -> bool:
+        """
+        Returns True if this window intersects the given window.
+        """
+        return self.start <= other.end and self.end >= other.start
+
+    def cover(self, other: 'TimeWindow') -> 'TimeWindow':
+        """
+        Returns the minimal window covers both this window and the given window.
+        """
+        return TimeWindow(min(self.start, other.start), max(self.end, other.end))
+
+    @staticmethod
+    def get_window_start_with_offset(timestamp: int, offset: int, window_size: int):
+        """
+        Method to get the window start for a timestamp.

Review comment:
       Leaving a blank line between the description and parameters will be more readable

##########
File path: flink-python/pyflink/fn_execution/coder_impl_fast.pyx
##########
@@ -811,6 +813,42 @@ cdef class FlattenRowCoderImpl(BaseCoderImpl):
         if self._field_coder_type:
             free(self._field_coder_type)
 
+cdef class WindowCoderImpl(BaseCoderImpl):
+    def __init__(self):
+        self._tmp_output_pos = 0
+        self._tmp_output_data = <char*> malloc(16)
+
+    cpdef bytes encode_nested(self, value):
+        pass
+
+    cdef void _encode_bigint(self, libc.stdint.int64_t v):
+        self._tmp_output_data[self._tmp_output_pos] = <unsigned char> (v >> 56)
+        self._tmp_output_data[self._tmp_output_pos + 1] = <unsigned char> (v >> 48)
+        self._tmp_output_data[self._tmp_output_pos + 2] = <unsigned char> (v >> 40)
+        self._tmp_output_data[self._tmp_output_pos + 3] = <unsigned char> (v >> 32)
+        self._tmp_output_data[self._tmp_output_pos + 4] = <unsigned char> (v >> 24)
+        self._tmp_output_data[self._tmp_output_pos + 5] = <unsigned char> (v >> 16)
+        self._tmp_output_data[self._tmp_output_pos + 6] = <unsigned char> (v >> 8)
+        self._tmp_output_data[self._tmp_output_pos + 7] = <unsigned char> v
+        self._tmp_output_pos += 8
+
+    def __dealloc__(self):
+        if self._tmp_output_data:
+            free(self._tmp_output_data)
+
+cdef class TimeWindowCoderImpl(WindowCoderImpl):
+

Review comment:
       Unnecessary blank line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770162262


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit daece76bc00e4dd9aab27b59c16fd67d57cc24d6 (Sat Jan 30 05:43:59 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21202).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * daece76bc00e4dd9aab27b59c16fd67d57cc24d6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690) 
   * 8e01d37ab94d0b54c3e0fb1bc4d643036145042d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] HuangXingBo closed pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
HuangXingBo closed pull request #14816:
URL: https://github.com/apache/flink/pull/14816


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] HuangXingBo commented on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-788723342


   The failed test has been reported in [FLINK-21519](https://issues.apache.org/jira/browse/FLINK-21519) which is not relevant to this PR. I will merge it first.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694",
       "triggerID" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc222cffd760e24ee61008fc45575ae3fce78506",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bc222cffd760e24ee61008fc45575ae3fce78506",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e01d37ab94d0b54c3e0fb1bc4d643036145042d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694) 
   * bc222cffd760e24ee61008fc45575ae3fce78506 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * daece76bc00e4dd9aab27b59c16fd67d57cc24d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * daece76bc00e4dd9aab27b59c16fd67d57cc24d6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694",
       "triggerID" : "8e01d37ab94d0b54c3e0fb1bc4d643036145042d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc222cffd760e24ee61008fc45575ae3fce78506",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13964",
       "triggerID" : "bc222cffd760e24ee61008fc45575ae3fce78506",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e01d37ab94d0b54c3e0fb1bc4d643036145042d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13694) 
   * bc222cffd760e24ee61008fc45575ae3fce78506 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13964) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14816: [FLINK-21202][python] Introduce TimeWindow and CountWindow in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14816:
URL: https://github.com/apache/flink/pull/14816#issuecomment-770164177


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690",
       "triggerID" : "daece76bc00e4dd9aab27b59c16fd67d57cc24d6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * daece76bc00e4dd9aab27b59c16fd67d57cc24d6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12690) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org