[GitHub] [airflow] ashb commented on a change in pull request #11384: Mutual SSL added in PGBouncer configuration in the Chart

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #11384:
URL: https://github.com/apache/airflow/pull/11384#discussion_r502686520



##########
File path: chart/templates/_helpers.yaml
##########
@@ -262,6 +266,13 @@ max_client_conn = {{ .Values.pgbouncer.maxClientConn }}
 verbose = {{ .Values.pgbouncer.verbose }}
 log_disconnections = {{ .Values.pgbouncer.logDisconnections }}
 log_connections = {{ .Values.pgbouncer.logConnections }}
+
+server_tls_sslmode = {{ .Values.pgbouncer.sslmode }}
+server_tls_ca_file = /etc/pgbouncer/root.crt

Review comment:
       Do these not need to be guarded so we don't set out if the options are empty?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org