You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/02 23:00:57 UTC
[GitHub] [cordova-ios] dpogue opened a new pull request #885: Don't silently ignore creation of new windows
dpogue opened a new pull request #885:
URL: https://github.com/apache/cordova-ios/pull/885
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Currently, attempts to create new windows (via links with `target="_blank"` or JS `window.open`) for pages within the application have no effect and are silently ignored. (Links to pages outside the application trigger the allow-intent functionality and open in Safari.)
### Description
<!-- Describe your changes in detail -->
With this PR, the default behaviour will be to open those links in the **same** Web View (without creating a new window).
This also introduces a preference (`AllowNewWindows`) that allows the creation of a new UIViewController to present the new page in a new Web View frame on top of the existing Web View.
**Note:** This new window provides no controls, so it can only be closed with `window.close()` in JS.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Manual testing in a new Cordova app.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue merged pull request #885: Don't silently ignore creation of new windows
Posted by GitBox <gi...@apache.org>.
dpogue merged pull request #885:
URL: https://github.com/apache/cordova-ios/pull/885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #885: Don't silently ignore creation of new windows
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #885:
URL: https://github.com/apache/cordova-ios/pull/885#issuecomment-637852542
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=h1) Report
> Merging [#885](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/02448ceb3b837e66890e702879bac9298f8a896a&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #885 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 13 13
Lines 1676 1676
=======================================
Hits 1247 1247
Misses 429 429
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=footer). Last update [02448ce...5d6d780](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #885: Don't silently ignore creation of new windows
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #885:
URL: https://github.com/apache/cordova-ios/pull/885#issuecomment-637852542
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=h1) Report
> Merging [#885](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/02448ceb3b837e66890e702879bac9298f8a896a&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #885 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 13 13
Lines 1676 1676
=======================================
Hits 1247 1247
Misses 429 429
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=footer). Last update [02448ce...5d6d780](https://codecov.io/gh/apache/cordova-ios/pull/885?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] vbraun commented on pull request #885: Don't silently ignore creation of new windows
Posted by GitBox <gi...@apache.org>.
vbraun commented on pull request #885:
URL: https://github.com/apache/cordova-ios/pull/885#issuecomment-945679026
What about iframes with `target="_blank"` links? These now either replace the app, or open another window on top without any way for the app to close it.
E.g. embedded google maps has a `target="_blank"` link to open the full screen map. We want to embed it into our app as iframe, so `<allow-navigation href="https://*.google.com/*" />` must be set or iOS displays nothing. Then user clicks on the link in the iframe. Used to just not do anything (bad), now just replaces the app (worse).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org