You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "shreemaan-abhishek (via GitHub)" <gi...@apache.org> on 2024/03/28 07:25:38 UTC
[I] feat: apisix `enable_encrypt_fields` should support plugin fields that are deeply situated, array elements, etc. [apisix]
shreemaan-abhishek opened a new issue, #11099:
URL: https://github.com/apache/apisix/issues/11099
### Description
### Current Situation:
APISIX `enable_encrypt_fields` only supports sensitive fields situated within two levels of depth. ref:
https://github.com/apache/apisix/blob/cca94f103cf2c3fba80ddb0795a9d1bb8c1bce08/apisix/plugin.lua#L1011
and it would not be possilbe to specify fields like kafka logger's `brokers.sasl_config.password` in any of the following ways even if fields from multiple depth levels were supported because `brokers` is of type array.
```lua
encrypt_fields = { "brokers.sasl_config.password" }
-- or
encrypt_fields = { "brokers.foreach.sasl_config.password" }
-- or
encrypt_fields = { "brokers.all.sasl_config.password" }
```
### Expected Situation:
There should be a mechanism to include plugin fields for encryption regardless of their nature. Due to this limitation it's not possible to include fields like `kafka-logger`'s `brokers.sasl_config.password`, `aws-lambda`'s `secretKey`.
This limitation was found during the implementation of #11095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: apisix `enable_encrypt_fields` should support plugin fields that are deeply situated, array elements, etc. [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on issue #11099:
URL: https://github.com/apache/apisix/issues/11099#issuecomment-4021419660
Closing this due to inactivity. If there’s still interest in this feature, please let us know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: apisix `enable_encrypt_fields` should support plugin fields that are deeply situated, array elements, etc. [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11099:
URL: https://github.com/apache/apisix/issues/11099#issuecomment-2724220885
This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: apisix `enable_encrypt_fields` should support plugin fields that are deeply situated, array elements, etc. [apisix]
Posted by "starsz (via GitHub)" <gi...@apache.org>.
starsz commented on issue #11099:
URL: https://github.com/apache/apisix/issues/11099#issuecomment-2025094112
Could we check the type of the `plugin fields`, if it's an array, then we encrypt the values in this array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: apisix `enable_encrypt_fields` should support plugin fields that are deeply situated, array elements, etc. [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop closed issue #11099: feat: apisix `enable_encrypt_fields` should support plugin fields that are deeply situated, array elements, etc.
URL: https://github.com/apache/apisix/issues/11099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org