You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/18 17:21:42 UTC

[GitHub] [ratis-thirdparty] szetszwo commented on a diff in pull request #39: RATIS-1679. Shade io.perfmark:perfmark-api in ratis-thirdparty

szetszwo commented on code in PR #39:
URL: https://github.com/apache/ratis-thirdparty/pull/39#discussion_r949406702


##########
pom.xml:
##########
@@ -175,6 +178,11 @@
         <artifactId>metrics-ganglia</artifactId>
         <version>${shaded.dropwizard.ganglia.version}</version>
       </dependency>
+      <dependency>
+        <groupId>io.perfmark</groupId>
+        <artifactId>perfmark-api</artifactId>
+        <version>${shaded.perfmark.version}</version>
+      </dependency>

Review Comment:
   The io.perfmark dependency comes with gRPC so that we don't have add it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org