You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/01/07 14:26:47 UTC
Re: Review Request 29370: Agent requires restart for alerts to work
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29370/#review67020
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 26, 2014, 12:07 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29370/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 12:07 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-8885
> https://issues.apache.org/jira/browse/AMBARI-8885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like currently alerts use some sort of cached values. After enabling
> security security_enabled value is false in alerts. After restarting agent it
> changes to true.
> Agent should not require restart after enabling security for alerts to work.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65e608a
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 34911b5
>
> Diff: https://reviews.apache.org/r/29370/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 29370: Agent requires restart for alerts to work
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Jan. 7, 2015, 8:26 a.m., Jonathan Hurley wrote:
> > Ship It!
>
> Jonathan Hurley wrote:
> I agree that we should open a new Jira to track the framework change. I'll do that. Submitting this.
I think this issue has been pushed; we can close the review.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29370/#review67020
-----------------------------------------------------------
On Dec. 26, 2014, 12:07 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29370/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 12:07 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-8885
> https://issues.apache.org/jira/browse/AMBARI-8885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like currently alerts use some sort of cached values. After enabling
> security security_enabled value is false in alerts. After restarting agent it
> changes to true.
> Agent should not require restart after enabling security for alerts to work.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65e608a
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 34911b5
>
> Diff: https://reviews.apache.org/r/29370/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 29370: Agent requires restart for alerts to work
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Jan. 7, 2015, 8:26 a.m., Jonathan Hurley wrote:
> > Ship It!
I agree that we should open a new Jira to track the framework change. I'll do that. Submitting this.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29370/#review67020
-----------------------------------------------------------
On Dec. 26, 2014, 12:07 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29370/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 12:07 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-8885
> https://issues.apache.org/jira/browse/AMBARI-8885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like currently alerts use some sort of cached values. After enabling
> security security_enabled value is false in alerts. After restarting agent it
> changes to true.
> Agent should not require restart after enabling security for alerts to work.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65e608a
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 34911b5
>
> Diff: https://reviews.apache.org/r/29370/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 29370: Agent requires restart for alerts to work
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Jan. 7, 2015, 8:26 a.m., Jonathan Hurley wrote:
> > Ship It!
>
> Jonathan Hurley wrote:
> I agree that we should open a new Jira to track the framework change. I'll do that. Submitting this.
>
> Jonathan Hurley wrote:
> I think this issue has been pushed; we can close the review.
>
> Jonathan Hurley wrote:
> Ping. Review can be closed.
Ping. Review can be closed.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29370/#review67020
-----------------------------------------------------------
On Dec. 26, 2014, 12:07 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29370/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 12:07 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-8885
> https://issues.apache.org/jira/browse/AMBARI-8885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like currently alerts use some sort of cached values. After enabling
> security security_enabled value is false in alerts. After restarting agent it
> changes to true.
> Agent should not require restart after enabling security for alerts to work.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65e608a
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 34911b5
>
> Diff: https://reviews.apache.org/r/29370/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 29370: Agent requires restart for alerts to work
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Jan. 7, 2015, 8:26 a.m., Jonathan Hurley wrote:
> > Ship It!
>
> Jonathan Hurley wrote:
> I agree that we should open a new Jira to track the framework change. I'll do that. Submitting this.
>
> Jonathan Hurley wrote:
> I think this issue has been pushed; we can close the review.
Ping. Review can be closed.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29370/#review67020
-----------------------------------------------------------
On Dec. 26, 2014, 12:07 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29370/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 12:07 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-8885
> https://issues.apache.org/jira/browse/AMBARI-8885
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like currently alerts use some sort of cached values. After enabling
> security security_enabled value is false in alerts. After restarting agent it
> changes to true.
> Agent should not require restart after enabling security for alerts to work.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65e608a
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 34911b5
>
> Diff: https://reviews.apache.org/r/29370/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>