You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/12/31 16:17:07 UTC

[GitHub] [netbeans] rs333 edited a comment on pull request #2625: [NETBEANS-4256] Fixed inconsistent xml fontcolor tag names.

rs333 edited a comment on pull request #2625:
URL: https://github.com/apache/netbeans/pull/2625#issuecomment-752995993


   > Thank you - I have the following comments:
   > 
   >     * [ ]  Are the changes to java files really necessary? While I see, that the change to `ide/xml.lexer/src/org/netbeans/api/xml/lexer/XMLTokenId.java` creates consistency, I wonder if the change to `ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java` is needed.
   
   I agree the file in the xml.text.obsolete90 folder need not be changed.  I can remove those changes.  
    
   >     * [ ]  Did you check if the code base uses the changes primary-category/name?
   If I understand your question correction, yes.    There is one file which does not appear to be used anymore (like the one from the first comment) which I did not change that references `pi-content`.  It is 
   `ide/xml.text/test/qa-functional/src/org/netbeans/modules/xml/text/syntax/data/goldenfiles/ColoringTest/testXMLColoring.pass`
   
   >     * [ ]   Your git configuration is broken, the author information is invalid. Please ensure, that you commit with your real name and a valid email address. You can check the used information with the git command line client and running  `git log -n 1` from the branch you used to create this PR.
   
   Will fix this.  
   
   >     * [ ]  Are you aware, that you donate the change to the ASF and agree to that (see the comment at the top of the files you change)?
    yes
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists