You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "thomasrebele (via GitHub)" <gi...@apache.org> on 2026/07/10 10:40:55 UTC

[PR] [CALCITE-6393] Add bytecode verification check using ASM in the gradle build [calcite]

thomasrebele opened a new pull request, #5090:
URL: https://github.com/apache/calcite/pull/5090

   This is a rebase of @zabetak's PR https://github.com/apache/calcite/pull/3783. I've fixed some warnings by adapting AsmCheckerTask to Gradle 8. I had to exclude `spark/build/sparkServer/classes`, as the classes in that dir failed the check.
   
   I've verified the functionality by building with JDK8. It indeed produces `java.lang.RuntimeException: Invalid bytecode file:/home/trebele/dev/calcite/c1/core/build/classes/java/main/org/apache/calcite/runtime/SqlFunctions.class` when running `./gradlew build`. The build passes with JDK17 and JDK21.
   
   Here the versions that I've used:
   ```
   $ /usr/lib/jvm/java-8-openjdk-amd64/bin/java -version
   openjdk version "1.8.0_492"
   OpenJDK Runtime Environment (build 1.8.0_492-8u492-ga~us2-0ubuntu1~24.04.1-b09)
   OpenJDK 64-Bit Server VM (build 25.492-b09, mixed mode)
   $ /usr/lib/jvm/java-17-openjdk-amd64/bin/java -version
   openjdk version "17.0.19" 2026-04-21
   OpenJDK Runtime Environment (build 17.0.19+10-1-24.04.2-Ubuntu)
   OpenJDK 64-Bit Server VM (build 17.0.19+10-1-24.04.2-Ubuntu, mixed mode, sharing)
   $ /usr/lib/jvm/java-21-openjdk-amd64/bin/java -version
   openjdk version "21.0.11" 2026-04-21
   OpenJDK Runtime Environment (build 21.0.11+10-1-24.04.2-Ubuntu)
   OpenJDK 64-Bit Server VM (build 21.0.11+10-1-24.04.2-Ubuntu, mixed mode, sharing)
   ```
   
   ## Jira Link
   
   [CALCITE-6393](https://issues.apache.org/jira/browse/CALCITE-6393)
   
   ## Changes Proposed
   This PR proposes to add a check to fail the build if it produced invalid bytecode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6393] Add bytecode verification check using ASM in the gradle build [calcite]

Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele closed pull request #5090: [CALCITE-6393] Add bytecode verification check using ASM in the gradle build
URL: https://github.com/apache/calcite/pull/5090


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6393] Add bytecode verification check using ASM in the gradle build [calcite]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5090:
URL: https://github.com/apache/calcite/pull/5090#issuecomment-4934662341

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5090) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5090&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5090&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5090&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5090&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5090&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5090)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-6393] Add bytecode verification check using ASM in the gradle build [calcite]

Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele commented on PR #5090:
URL: https://github.com/apache/calcite/pull/5090#issuecomment-4935864207

   Superseded by https://github.com/apache/calcite/pull/5092.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org