You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "wangmiao1002 (via GitHub)" <gi...@apache.org> on 2023/03/10 15:51:15 UTC
[GitHub] [kyuubi] wangmiao1002 opened a new pull request, #4494: Modify script run_kyuubi mode
wangmiao1002 opened a new pull request, #4494:
URL: https://github.com/apache/kyuubi/pull/4494
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Modify run_ Kyuubi's startup command is suitable for cm
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4494: `bin/kyuubi` should use `exec` to run Kyuubi server
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4494:
URL: https://github.com/apache/kyuubi/pull/4494#issuecomment-1464030703
@wangmiao1002 thanks for contributing, I modified your PR title from "Modify script run_kyuubi mode" to "bin/kyuubi should use exec to run Kyuubi server", the naming principle is try your best to make it short and precise, would you mind update the PR description to supply more details and background about this change? To un-surprise users who revisit this PR in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4494: `bin/kyuubi` should use `exec` to run Kyuubi server
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4494:
URL: https://github.com/apache/kyuubi/pull/4494#issuecomment-1464046618
Thanks, merged to master/1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] wangmiao1002 commented on pull request #4494: `bin/kyuubi` should use `exec` to run Kyuubi server
Posted by "wangmiao1002 (via GitHub)" <gi...@apache.org>.
wangmiao1002 commented on PR #4494:
URL: https://github.com/apache/kyuubi/pull/4494#issuecomment-1464803651
Thank you for your modification. It looks great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4494: `bin/kyuubi` should use `exec` to run Kyuubi server
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4494:
URL: https://github.com/apache/kyuubi/pull/4494#issuecomment-1464054502
After linking the mail account to your GitHub account, your avatar will present in the commit history https://github.com/apache/kyuubi/commit/f420238f4f171bab9a04860c5cf7f6b2181621ec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4494: `bin/kyuubi` should use `exec` to run Kyuubi server
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4494:
URL: https://github.com/apache/kyuubi/pull/4494#issuecomment-1464051025
@wangmiao1002 your git commit username and mail is `miaowang <mi...@gaojihealth.com>`, seems the mail does not linked your GitHub account, thus your contribution is not counted by GitHub, would you like to update your GitHub profile to link the mail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4494: `bin/kyuubi` should use `exec` to run Kyuubi server
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4494: `bin/kyuubi` should use `exec` to run Kyuubi server
URL: https://github.com/apache/kyuubi/pull/4494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org