You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@heron.apache.org by Ning Wang <wa...@gmail.com> on 2019/04/26 04:17:23 UTC
[RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate 2
(Second Pass)
Hi,
A memory leak issue was reported with this release, plus a fix is needed
for status script. I am closing this vote now and will prepare a new
release candidate after the issues are resolved.
Thanks a lot for all the help!
--ning
On Sun, Apr 21, 2019 at 11:30 PM Ning Wang <wa...@gmail.com> wrote:
>
>
> On Fri, Apr 19, 2019 at 11:52 AM Ning Wang <wa...@gmail.com> wrote:
>
>> Hi, dear Mentors,
>>
>> Please help if you have time. :) Thanks in advance.
>>
>> --ning
>>
>>
>> On Fri, Apr 19, 2019 at 11:50 AM Ning Wang <wa...@gmail.com> wrote:
>>
>>> *Hello, Heron Community,*
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> *This is a call for a vote to the 2nd release candidate for Apache
>>> Heron, version v0.20.1-incubating. This is a second pass since Dave pointed
>>> out a few things that we weren’t clear before. The git tag is the same as
>>> the last time and the previous votes (four +1s from thinker0, Karthik
>>> Ramasamy, Josh Fischer, Simong Weng) will be carried over.The release will
>>> be source only and I am going to remove the binary packages. We need to
>>> reduce the size and another review before including them in the release.The
>>> tag to be voted upon:0.20.1-incubating-rc2
>>> (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of changes and
>>> release notes are available
>>> at:https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
>>> <https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2>Release
>>> files can be found in dist.apache.org <http://dist.apache.org>
>>> site:https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
>>> <https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/>Source:
>>> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
>>> <https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz>ASC
>>> signature:
>>> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
>>> <https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc>SHA512:
>>> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
>>> <https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512>c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3
>>> incubator-heron-0.20.1-incubating-rc2.tar.gzThe artifacts are signed with
>>> PGP key 293DB72F865688D1, corresponding to nwang@apache.org
>>> <nw...@apache.org>, that can be found in keys
>>> file:https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
>>> <https://dist.apache.org/repos/dist/release/incubator/heron/KEYS>Please
>>> download the source package, and follow the compiling
>>> guide(https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
>>> <https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/>)to
>>> build and run the Heron locally. Note that currently Bazel 0.14.1 is
>>> required to build this version.For your convenience, here are a few
>>> commands I used:License check:$ java -jar ~/Downloads/apache-rat-0.12.jar .
>>> -E .rat-excludesBuild the binary package for Mac OS:$ sh
>>> scripts/ci/build_release_packages.sh v0.20.1-incubating-rc2 darwin
>>> artifactsBuild the docker image for Debian 9$ bash
>>> scripts/ci/build_docker_image.sh v0.20.1-incubating-rc2 debian9
>>> artifactsThe vote will be open for at least 72 hours or until the necessary
>>> number of votes are reached. Hopefully we can get enough (three) votes from
>>> mentors.Please vote accordingly:[ ] +1 approve[ ] +0 no opinion[ ] -1
>>> disapprove with the reasonThanks,The Apache Heron (Incubating) Team*
>>>
>>
Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate
2 (Second Pass)
Posted by Dmitry Rusakov <dr...@twitter.com.INVALID>.
Hi, Julien!
> Q: Do you have a way to tests for memory leaks as part of unit tests?
> Q: Do you have other ways to detect that as part of the release process?
We are thinking about a startup *command line flag* that will (if present)
run all native components under Valgrind.
I will get back when i have more details about it.
On Mon, Apr 29, 2019 at 11:54 AM Ning Wang <wa...@gmail.com> wrote:
> Dmitry is working on Valgrind related things. ^^
>
> On Sat, Apr 27, 2019 at 8:57 PM Xiaoyao Qian <qi...@illinois.edu> wrote:
>
> > To turn on heapcheck, just need to set ENABLE_HEAPCHECK=1 in the build
> > environment. The heapcheck report will be at the end of
> > heron-executor-*.stdout when the executor instance gracefully shuts
> down. I
> > was having a hard time decoding the heapcheck report into human readable
> > format though. Dmitry had some luck with valgrind.
> >
> > Xiaoyao Qian
> >
> > On Fri, Apr 26, 2019 at 7:43 PM Ning Wang <wa...@gmail.com> wrote:
> >
> > > We use it to verify the memory leak was fixed, but I am not sure if it
> > is a
> > > report or it can cause a build error. Xiaoyao should know better.
> > >
> > > Also Dmitry was using valgrind for debugging and he is looking the best
> > way
> > > to turn it on.
> > >
> > > On Fri, Apr 26, 2019 at 6:13 PM Julien Le Dem
> > > <ju...@wework.com.invalid> wrote:
> > >
> > > > On Thu, Apr 25, 2019 at 9:43 PM Ning Wang <wa...@gmail.com>
> > wrote:
> > > >
> > > > > Thans Julien!
> > > > >
> > > > > For the release check instructions, here is a tracking ticket:
> > > > > https://github.com/apache/incubator-heron/issues/3246
> > > > >
> > > > > thanks
> > > >
> > > > > About the other questions:
> > > > > Q: Do you have a way to tests for memory leaks as part of unit
> tests?
> > > > > Yes. We have heap check with unit tests as well as integration
> tests.
> > > > >
> > > > > does that fail the build? I didn't see it when running locally.
> > > >
> > > >
> > > > > Q: Do you have other ways to detect that as part of the release
> > > process?
> > > > > Currently we are relying on integration tests. Internally we have a
> > > > canary
> > > > > process but externally users have very different environments and
> > there
> > > > is
> > > > > no canary setup.
> > > > >
> > > > >
> > > > >
> > > > > On Thu, Apr 25, 2019 at 9:29 PM Julien Le Dem
> > > > > <ju...@wework.com.invalid> wrote:
> > > > >
> > > > > > For what it's worth.
> > > > > > I was able to build, verify the signature and run the rat report.
> > So
> > > I
> > > > > was
> > > > > > going to vote when thinker0 reported the issue.
> > > > > > It would be nice to have clear an precise step by step
> instructions
> > > for
> > > > > > validating the release. (and specifically the release)
> > > > > > For example, the apache arrow project has a nice script that
> > > automates
> > > > it
> > > > > > all:
> > > https://github.com/apache/arrow/blob/master/dev/release/VERIFY.md
> > > > > > That would improve the turn around on mentors voting on the
> > release.
> > > > > > Do you have a way to tests for memory leaks as part of unit
> tests?
> > > > > > Do you have other ways to detect that as part of the release
> > process?
> > > > > > Thanks
> > > > > > Julien
> > > > > >
> > > > > >
> > > > > > On Thu, Apr 25, 2019 at 9:21 PM Ning Wang <wa...@gmail.com>
> > > > wrote:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > A memory leak issue was reported with this release, plus a fix
> is
> > > > > needed
> > > > > > > for status script. I am closing this vote now and will prepare
> a
> > > new
> > > > > > > release candidate after the issues are resolved.
> > > > > > >
> > > > > > > Thanks a lot for all the help!
> > > > > > >
> > > > > > > --ning
> > > > > > >
> > > > > > >
> > > > > > > On Sun, Apr 21, 2019 at 11:30 PM Ning Wang <
> wangninggm@gmail.com
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Fri, Apr 19, 2019 at 11:52 AM Ning Wang <
> > wangninggm@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > >
> > > > > > > >> Hi, dear Mentors,
> > > > > > > >>
> > > > > > > >> Please help if you have time. :) Thanks in advance.
> > > > > > > >>
> > > > > > > >> --ning
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> On Fri, Apr 19, 2019 at 11:50 AM Ning Wang <
> > > wangninggm@gmail.com>
> > > > > > > wrote:
> > > > > > > >>
> > > > > > > >>> *Hello, Heron Community,*
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>>
> > > > > > > >>> *This is a call for a vote to the 2nd release candidate for
> > > > Apache
> > > > > > > >>> Heron, version v0.20.1-incubating. This is a second pass
> > since
> > > > Dave
> > > > > > > pointed
> > > > > > > >>> out a few things that we weren’t clear before. The git tag
> is
> > > the
> > > > > > same
> > > > > > > as
> > > > > > > >>> the last time and the previous votes (four +1s from
> thinker0,
> > > > > Karthik
> > > > > > > >>> Ramasamy, Josh Fischer, Simong Weng) will be carried
> over.The
> > > > > release
> > > > > > > will
> > > > > > > >>> be source only and I am going to remove the binary
> packages.
> > We
> > > > > need
> > > > > > to
> > > > > > > >>> reduce the size and another review before including them in
> > the
> > > > > > > release.The
> > > > > > > >>> tag to be voted upon:0.20.1-incubating-rc2
> > > > > > > >>> (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of
> > > > changes
> > > > > > and
> > > > > > > >>> release notes are available
> > > > > > > >>> at:
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > > > > > >>> <
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > > > > > >Release
> > > > > > > >>> files can be found in dist.apache.org <
> > http://dist.apache.org>
> > > > > > > >>> site:
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > > > > > >>> <
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > > > > > >Source:
> > > > > > > >>>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > > > > > >>> <
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > > > > > >ASC
> > > > > > > >>> signature:
> > > > > > > >>>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > > > > > >>> <
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > > > > > >SHA512:
> > > > > > > >>>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > > > > > >>> <
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3
> > > > > > > >>> incubator-heron-0.20.1-incubating-rc2.tar.gzThe artifacts
> > are
> > > > > signed
> > > > > > > with
> > > > > > > >>> PGP key 293DB72F865688D1, corresponding to
> nwang@apache.org
> > > > > > > >>> <nw...@apache.org>, that can be found in keys
> > > > > > > >>> file:
> > > > > https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > > > > > >>> <
> > > https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > > > > > >Please
> > > > > > > >>> download the source package, and follow the compiling
> > > > > > > >>> guide(
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > > > > > >>> <
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > > > > > >)to
> > > > > > > >>> build and run the Heron locally. Note that currently Bazel
> > > 0.14.1
> > > > > is
> > > > > > > >>> required to build this version.For your convenience, here
> > are a
> > > > few
> > > > > > > >>> commands I used:License check:$ java -jar
> > > > > > > ~/Downloads/apache-rat-0.12.jar .
> > > > > > > >>> -E .rat-excludesBuild the binary package for Mac OS:$ sh
> > > > > > > >>> scripts/ci/build_release_packages.sh v0.20.1-incubating-rc2
> > > > darwin
> > > > > > > >>> artifactsBuild the docker image for Debian 9$ bash
> > > > > > > >>> scripts/ci/build_docker_image.sh v0.20.1-incubating-rc2
> > debian9
> > > > > > > >>> artifactsThe vote will be open for at least 72 hours or
> until
> > > the
> > > > > > > necessary
> > > > > > > >>> number of votes are reached. Hopefully we can get enough
> > > (three)
> > > > > > votes
> > > > > > > from
> > > > > > > >>> mentors.Please vote accordingly:[ ] +1 approve[ ] +0 no
> > > opinion[
> > > > ]
> > > > > -1
> > > > > > > >>> disapprove with the reasonThanks,The Apache Heron
> > (Incubating)
> > > > > Team*
> > > > > > > >>>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
Dmitry Rusakov,
Senior Software Engineer,
Twitter CDM team
Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate
2 (Second Pass)
Posted by Ning Wang <wa...@gmail.com>.
Dmitry is working on Valgrind related things. ^^
On Sat, Apr 27, 2019 at 8:57 PM Xiaoyao Qian <qi...@illinois.edu> wrote:
> To turn on heapcheck, just need to set ENABLE_HEAPCHECK=1 in the build
> environment. The heapcheck report will be at the end of
> heron-executor-*.stdout when the executor instance gracefully shuts down. I
> was having a hard time decoding the heapcheck report into human readable
> format though. Dmitry had some luck with valgrind.
>
> Xiaoyao Qian
>
> On Fri, Apr 26, 2019 at 7:43 PM Ning Wang <wa...@gmail.com> wrote:
>
> > We use it to verify the memory leak was fixed, but I am not sure if it
> is a
> > report or it can cause a build error. Xiaoyao should know better.
> >
> > Also Dmitry was using valgrind for debugging and he is looking the best
> way
> > to turn it on.
> >
> > On Fri, Apr 26, 2019 at 6:13 PM Julien Le Dem
> > <ju...@wework.com.invalid> wrote:
> >
> > > On Thu, Apr 25, 2019 at 9:43 PM Ning Wang <wa...@gmail.com>
> wrote:
> > >
> > > > Thans Julien!
> > > >
> > > > For the release check instructions, here is a tracking ticket:
> > > > https://github.com/apache/incubator-heron/issues/3246
> > > >
> > > > thanks
> > >
> > > > About the other questions:
> > > > Q: Do you have a way to tests for memory leaks as part of unit tests?
> > > > Yes. We have heap check with unit tests as well as integration tests.
> > > >
> > > > does that fail the build? I didn't see it when running locally.
> > >
> > >
> > > > Q: Do you have other ways to detect that as part of the release
> > process?
> > > > Currently we are relying on integration tests. Internally we have a
> > > canary
> > > > process but externally users have very different environments and
> there
> > > is
> > > > no canary setup.
> > > >
> > > >
> > > >
> > > > On Thu, Apr 25, 2019 at 9:29 PM Julien Le Dem
> > > > <ju...@wework.com.invalid> wrote:
> > > >
> > > > > For what it's worth.
> > > > > I was able to build, verify the signature and run the rat report.
> So
> > I
> > > > was
> > > > > going to vote when thinker0 reported the issue.
> > > > > It would be nice to have clear an precise step by step instructions
> > for
> > > > > validating the release. (and specifically the release)
> > > > > For example, the apache arrow project has a nice script that
> > automates
> > > it
> > > > > all:
> > https://github.com/apache/arrow/blob/master/dev/release/VERIFY.md
> > > > > That would improve the turn around on mentors voting on the
> release.
> > > > > Do you have a way to tests for memory leaks as part of unit tests?
> > > > > Do you have other ways to detect that as part of the release
> process?
> > > > > Thanks
> > > > > Julien
> > > > >
> > > > >
> > > > > On Thu, Apr 25, 2019 at 9:21 PM Ning Wang <wa...@gmail.com>
> > > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > A memory leak issue was reported with this release, plus a fix is
> > > > needed
> > > > > > for status script. I am closing this vote now and will prepare a
> > new
> > > > > > release candidate after the issues are resolved.
> > > > > >
> > > > > > Thanks a lot for all the help!
> > > > > >
> > > > > > --ning
> > > > > >
> > > > > >
> > > > > > On Sun, Apr 21, 2019 at 11:30 PM Ning Wang <wangninggm@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Apr 19, 2019 at 11:52 AM Ning Wang <
> wangninggm@gmail.com
> > >
> > > > > wrote:
> > > > > > >
> > > > > > >> Hi, dear Mentors,
> > > > > > >>
> > > > > > >> Please help if you have time. :) Thanks in advance.
> > > > > > >>
> > > > > > >> --ning
> > > > > > >>
> > > > > > >>
> > > > > > >> On Fri, Apr 19, 2019 at 11:50 AM Ning Wang <
> > wangninggm@gmail.com>
> > > > > > wrote:
> > > > > > >>
> > > > > > >>> *Hello, Heron Community,*
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>>
> > > > > > >>> *This is a call for a vote to the 2nd release candidate for
> > > Apache
> > > > > > >>> Heron, version v0.20.1-incubating. This is a second pass
> since
> > > Dave
> > > > > > pointed
> > > > > > >>> out a few things that we weren’t clear before. The git tag is
> > the
> > > > > same
> > > > > > as
> > > > > > >>> the last time and the previous votes (four +1s from thinker0,
> > > > Karthik
> > > > > > >>> Ramasamy, Josh Fischer, Simong Weng) will be carried over.The
> > > > release
> > > > > > will
> > > > > > >>> be source only and I am going to remove the binary packages.
> We
> > > > need
> > > > > to
> > > > > > >>> reduce the size and another review before including them in
> the
> > > > > > release.The
> > > > > > >>> tag to be voted upon:0.20.1-incubating-rc2
> > > > > > >>> (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of
> > > changes
> > > > > and
> > > > > > >>> release notes are available
> > > > > > >>> at:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > > > > >>> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > > > > >Release
> > > > > > >>> files can be found in dist.apache.org <
> http://dist.apache.org>
> > > > > > >>> site:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > > > > >>> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > > > > >Source:
> > > > > > >>>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > > > > >>> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > > > > >ASC
> > > > > > >>> signature:
> > > > > > >>>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > > > > >>> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > > > > >SHA512:
> > > > > > >>>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > > > > >>> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > > > >
> > > > >
> > > >
> > >
> >
> >c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3
> > > > > > >>> incubator-heron-0.20.1-incubating-rc2.tar.gzThe artifacts
> are
> > > > signed
> > > > > > with
> > > > > > >>> PGP key 293DB72F865688D1, corresponding to nwang@apache.org
> > > > > > >>> <nw...@apache.org>, that can be found in keys
> > > > > > >>> file:
> > > > https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > > > > >>> <
> > https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > > > > >Please
> > > > > > >>> download the source package, and follow the compiling
> > > > > > >>> guide(
> > > > > >
> > > > >
> > > >
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > > > > >>> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > > > > >)to
> > > > > > >>> build and run the Heron locally. Note that currently Bazel
> > 0.14.1
> > > > is
> > > > > > >>> required to build this version.For your convenience, here
> are a
> > > few
> > > > > > >>> commands I used:License check:$ java -jar
> > > > > > ~/Downloads/apache-rat-0.12.jar .
> > > > > > >>> -E .rat-excludesBuild the binary package for Mac OS:$ sh
> > > > > > >>> scripts/ci/build_release_packages.sh v0.20.1-incubating-rc2
> > > darwin
> > > > > > >>> artifactsBuild the docker image for Debian 9$ bash
> > > > > > >>> scripts/ci/build_docker_image.sh v0.20.1-incubating-rc2
> debian9
> > > > > > >>> artifactsThe vote will be open for at least 72 hours or until
> > the
> > > > > > necessary
> > > > > > >>> number of votes are reached. Hopefully we can get enough
> > (three)
> > > > > votes
> > > > > > from
> > > > > > >>> mentors.Please vote accordingly:[ ] +1 approve[ ] +0 no
> > opinion[
> > > ]
> > > > -1
> > > > > > >>> disapprove with the reasonThanks,The Apache Heron
> (Incubating)
> > > > Team*
> > > > > > >>>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate
2 (Second Pass)
Posted by Xiaoyao Qian <qi...@illinois.edu>.
To turn on heapcheck, just need to set ENABLE_HEAPCHECK=1 in the build
environment. The heapcheck report will be at the end of
heron-executor-*.stdout when the executor instance gracefully shuts down. I
was having a hard time decoding the heapcheck report into human readable
format though. Dmitry had some luck with valgrind.
Xiaoyao Qian
On Fri, Apr 26, 2019 at 7:43 PM Ning Wang <wa...@gmail.com> wrote:
> We use it to verify the memory leak was fixed, but I am not sure if it is a
> report or it can cause a build error. Xiaoyao should know better.
>
> Also Dmitry was using valgrind for debugging and he is looking the best way
> to turn it on.
>
> On Fri, Apr 26, 2019 at 6:13 PM Julien Le Dem
> <ju...@wework.com.invalid> wrote:
>
> > On Thu, Apr 25, 2019 at 9:43 PM Ning Wang <wa...@gmail.com> wrote:
> >
> > > Thans Julien!
> > >
> > > For the release check instructions, here is a tracking ticket:
> > > https://github.com/apache/incubator-heron/issues/3246
> > >
> > > thanks
> >
> > > About the other questions:
> > > Q: Do you have a way to tests for memory leaks as part of unit tests?
> > > Yes. We have heap check with unit tests as well as integration tests.
> > >
> > > does that fail the build? I didn't see it when running locally.
> >
> >
> > > Q: Do you have other ways to detect that as part of the release
> process?
> > > Currently we are relying on integration tests. Internally we have a
> > canary
> > > process but externally users have very different environments and there
> > is
> > > no canary setup.
> > >
> > >
> > >
> > > On Thu, Apr 25, 2019 at 9:29 PM Julien Le Dem
> > > <ju...@wework.com.invalid> wrote:
> > >
> > > > For what it's worth.
> > > > I was able to build, verify the signature and run the rat report. So
> I
> > > was
> > > > going to vote when thinker0 reported the issue.
> > > > It would be nice to have clear an precise step by step instructions
> for
> > > > validating the release. (and specifically the release)
> > > > For example, the apache arrow project has a nice script that
> automates
> > it
> > > > all:
> https://github.com/apache/arrow/blob/master/dev/release/VERIFY.md
> > > > That would improve the turn around on mentors voting on the release.
> > > > Do you have a way to tests for memory leaks as part of unit tests?
> > > > Do you have other ways to detect that as part of the release process?
> > > > Thanks
> > > > Julien
> > > >
> > > >
> > > > On Thu, Apr 25, 2019 at 9:21 PM Ning Wang <wa...@gmail.com>
> > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > A memory leak issue was reported with this release, plus a fix is
> > > needed
> > > > > for status script. I am closing this vote now and will prepare a
> new
> > > > > release candidate after the issues are resolved.
> > > > >
> > > > > Thanks a lot for all the help!
> > > > >
> > > > > --ning
> > > > >
> > > > >
> > > > > On Sun, Apr 21, 2019 at 11:30 PM Ning Wang <wa...@gmail.com>
> > > wrote:
> > > > >
> > > > > >
> > > > > >
> > > > > > On Fri, Apr 19, 2019 at 11:52 AM Ning Wang <wangninggm@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > >> Hi, dear Mentors,
> > > > > >>
> > > > > >> Please help if you have time. :) Thanks in advance.
> > > > > >>
> > > > > >> --ning
> > > > > >>
> > > > > >>
> > > > > >> On Fri, Apr 19, 2019 at 11:50 AM Ning Wang <
> wangninggm@gmail.com>
> > > > > wrote:
> > > > > >>
> > > > > >>> *Hello, Heron Community,*
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>>
> > > > > >>> *This is a call for a vote to the 2nd release candidate for
> > Apache
> > > > > >>> Heron, version v0.20.1-incubating. This is a second pass since
> > Dave
> > > > > pointed
> > > > > >>> out a few things that we weren’t clear before. The git tag is
> the
> > > > same
> > > > > as
> > > > > >>> the last time and the previous votes (four +1s from thinker0,
> > > Karthik
> > > > > >>> Ramasamy, Josh Fischer, Simong Weng) will be carried over.The
> > > release
> > > > > will
> > > > > >>> be source only and I am going to remove the binary packages. We
> > > need
> > > > to
> > > > > >>> reduce the size and another review before including them in the
> > > > > release.The
> > > > > >>> tag to be voted upon:0.20.1-incubating-rc2
> > > > > >>> (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of
> > changes
> > > > and
> > > > > >>> release notes are available
> > > > > >>> at:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > > > >>> <
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > > > >Release
> > > > > >>> files can be found in dist.apache.org <http://dist.apache.org>
> > > > > >>> site:
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > > > >>> <
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > > > >Source:
> > > > > >>>
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > > > >>> <
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > > > >ASC
> > > > > >>> signature:
> > > > > >>>
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > > > >>> <
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > > > >SHA512:
> > > > > >>>
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > > > >>> <
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > > >
> > > >
> > >
> >
> >c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3
> > > > > >>> incubator-heron-0.20.1-incubating-rc2.tar.gzThe artifacts are
> > > signed
> > > > > with
> > > > > >>> PGP key 293DB72F865688D1, corresponding to nwang@apache.org
> > > > > >>> <nw...@apache.org>, that can be found in keys
> > > > > >>> file:
> > > https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > > > >>> <
> https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > > > >Please
> > > > > >>> download the source package, and follow the compiling
> > > > > >>> guide(
> > > > >
> > > >
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > > > >>> <
> > > > >
> > > >
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > > > >)to
> > > > > >>> build and run the Heron locally. Note that currently Bazel
> 0.14.1
> > > is
> > > > > >>> required to build this version.For your convenience, here are a
> > few
> > > > > >>> commands I used:License check:$ java -jar
> > > > > ~/Downloads/apache-rat-0.12.jar .
> > > > > >>> -E .rat-excludesBuild the binary package for Mac OS:$ sh
> > > > > >>> scripts/ci/build_release_packages.sh v0.20.1-incubating-rc2
> > darwin
> > > > > >>> artifactsBuild the docker image for Debian 9$ bash
> > > > > >>> scripts/ci/build_docker_image.sh v0.20.1-incubating-rc2 debian9
> > > > > >>> artifactsThe vote will be open for at least 72 hours or until
> the
> > > > > necessary
> > > > > >>> number of votes are reached. Hopefully we can get enough
> (three)
> > > > votes
> > > > > from
> > > > > >>> mentors.Please vote accordingly:[ ] +1 approve[ ] +0 no
> opinion[
> > ]
> > > -1
> > > > > >>> disapprove with the reasonThanks,The Apache Heron (Incubating)
> > > Team*
> > > > > >>>
> > > > > >>
> > > > >
> > > >
> > >
> >
>
Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate
2 (Second Pass)
Posted by Ning Wang <wa...@gmail.com>.
We use it to verify the memory leak was fixed, but I am not sure if it is a
report or it can cause a build error. Xiaoyao should know better.
Also Dmitry was using valgrind for debugging and he is looking the best way
to turn it on.
On Fri, Apr 26, 2019 at 6:13 PM Julien Le Dem
<ju...@wework.com.invalid> wrote:
> On Thu, Apr 25, 2019 at 9:43 PM Ning Wang <wa...@gmail.com> wrote:
>
> > Thans Julien!
> >
> > For the release check instructions, here is a tracking ticket:
> > https://github.com/apache/incubator-heron/issues/3246
> >
> > thanks
>
> > About the other questions:
> > Q: Do you have a way to tests for memory leaks as part of unit tests?
> > Yes. We have heap check with unit tests as well as integration tests.
> >
> > does that fail the build? I didn't see it when running locally.
>
>
> > Q: Do you have other ways to detect that as part of the release process?
> > Currently we are relying on integration tests. Internally we have a
> canary
> > process but externally users have very different environments and there
> is
> > no canary setup.
> >
> >
> >
> > On Thu, Apr 25, 2019 at 9:29 PM Julien Le Dem
> > <ju...@wework.com.invalid> wrote:
> >
> > > For what it's worth.
> > > I was able to build, verify the signature and run the rat report. So I
> > was
> > > going to vote when thinker0 reported the issue.
> > > It would be nice to have clear an precise step by step instructions for
> > > validating the release. (and specifically the release)
> > > For example, the apache arrow project has a nice script that automates
> it
> > > all: https://github.com/apache/arrow/blob/master/dev/release/VERIFY.md
> > > That would improve the turn around on mentors voting on the release.
> > > Do you have a way to tests for memory leaks as part of unit tests?
> > > Do you have other ways to detect that as part of the release process?
> > > Thanks
> > > Julien
> > >
> > >
> > > On Thu, Apr 25, 2019 at 9:21 PM Ning Wang <wa...@gmail.com>
> wrote:
> > >
> > > > Hi,
> > > >
> > > > A memory leak issue was reported with this release, plus a fix is
> > needed
> > > > for status script. I am closing this vote now and will prepare a new
> > > > release candidate after the issues are resolved.
> > > >
> > > > Thanks a lot for all the help!
> > > >
> > > > --ning
> > > >
> > > >
> > > > On Sun, Apr 21, 2019 at 11:30 PM Ning Wang <wa...@gmail.com>
> > wrote:
> > > >
> > > > >
> > > > >
> > > > > On Fri, Apr 19, 2019 at 11:52 AM Ning Wang <wa...@gmail.com>
> > > wrote:
> > > > >
> > > > >> Hi, dear Mentors,
> > > > >>
> > > > >> Please help if you have time. :) Thanks in advance.
> > > > >>
> > > > >> --ning
> > > > >>
> > > > >>
> > > > >> On Fri, Apr 19, 2019 at 11:50 AM Ning Wang <wa...@gmail.com>
> > > > wrote:
> > > > >>
> > > > >>> *Hello, Heron Community,*
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>> *This is a call for a vote to the 2nd release candidate for
> Apache
> > > > >>> Heron, version v0.20.1-incubating. This is a second pass since
> Dave
> > > > pointed
> > > > >>> out a few things that we weren’t clear before. The git tag is the
> > > same
> > > > as
> > > > >>> the last time and the previous votes (four +1s from thinker0,
> > Karthik
> > > > >>> Ramasamy, Josh Fischer, Simong Weng) will be carried over.The
> > release
> > > > will
> > > > >>> be source only and I am going to remove the binary packages. We
> > need
> > > to
> > > > >>> reduce the size and another review before including them in the
> > > > release.The
> > > > >>> tag to be voted upon:0.20.1-incubating-rc2
> > > > >>> (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of
> changes
> > > and
> > > > >>> release notes are available
> > > > >>> at:
> > > >
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > > >>> <
> > > >
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > > >Release
> > > > >>> files can be found in dist.apache.org <http://dist.apache.org>
> > > > >>> site:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > > >>> <
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > > >Source:
> > > > >>>
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > > >>> <
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > > >ASC
> > > > >>> signature:
> > > > >>>
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > > >>> <
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > > >SHA512:
> > > > >>>
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > > >>> <
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > >
> > >
> >
> >c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3
> > > > >>> incubator-heron-0.20.1-incubating-rc2.tar.gzThe artifacts are
> > signed
> > > > with
> > > > >>> PGP key 293DB72F865688D1, corresponding to nwang@apache.org
> > > > >>> <nw...@apache.org>, that can be found in keys
> > > > >>> file:
> > https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > > >>> <https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > > >Please
> > > > >>> download the source package, and follow the compiling
> > > > >>> guide(
> > > >
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > > >>> <
> > > >
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > > >)to
> > > > >>> build and run the Heron locally. Note that currently Bazel 0.14.1
> > is
> > > > >>> required to build this version.For your convenience, here are a
> few
> > > > >>> commands I used:License check:$ java -jar
> > > > ~/Downloads/apache-rat-0.12.jar .
> > > > >>> -E .rat-excludesBuild the binary package for Mac OS:$ sh
> > > > >>> scripts/ci/build_release_packages.sh v0.20.1-incubating-rc2
> darwin
> > > > >>> artifactsBuild the docker image for Debian 9$ bash
> > > > >>> scripts/ci/build_docker_image.sh v0.20.1-incubating-rc2 debian9
> > > > >>> artifactsThe vote will be open for at least 72 hours or until the
> > > > necessary
> > > > >>> number of votes are reached. Hopefully we can get enough (three)
> > > votes
> > > > from
> > > > >>> mentors.Please vote accordingly:[ ] +1 approve[ ] +0 no opinion[
> ]
> > -1
> > > > >>> disapprove with the reasonThanks,The Apache Heron (Incubating)
> > Team*
> > > > >>>
> > > > >>
> > > >
> > >
> >
>
Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate
2 (Second Pass)
Posted by Julien Le Dem <ju...@wework.com.INVALID>.
On Thu, Apr 25, 2019 at 9:43 PM Ning Wang <wa...@gmail.com> wrote:
> Thans Julien!
>
> For the release check instructions, here is a tracking ticket:
> https://github.com/apache/incubator-heron/issues/3246
>
> thanks
> About the other questions:
> Q: Do you have a way to tests for memory leaks as part of unit tests?
> Yes. We have heap check with unit tests as well as integration tests.
>
> does that fail the build? I didn't see it when running locally.
> Q: Do you have other ways to detect that as part of the release process?
> Currently we are relying on integration tests. Internally we have a canary
> process but externally users have very different environments and there is
> no canary setup.
>
>
>
> On Thu, Apr 25, 2019 at 9:29 PM Julien Le Dem
> <ju...@wework.com.invalid> wrote:
>
> > For what it's worth.
> > I was able to build, verify the signature and run the rat report. So I
> was
> > going to vote when thinker0 reported the issue.
> > It would be nice to have clear an precise step by step instructions for
> > validating the release. (and specifically the release)
> > For example, the apache arrow project has a nice script that automates it
> > all: https://github.com/apache/arrow/blob/master/dev/release/VERIFY.md
> > That would improve the turn around on mentors voting on the release.
> > Do you have a way to tests for memory leaks as part of unit tests?
> > Do you have other ways to detect that as part of the release process?
> > Thanks
> > Julien
> >
> >
> > On Thu, Apr 25, 2019 at 9:21 PM Ning Wang <wa...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > A memory leak issue was reported with this release, plus a fix is
> needed
> > > for status script. I am closing this vote now and will prepare a new
> > > release candidate after the issues are resolved.
> > >
> > > Thanks a lot for all the help!
> > >
> > > --ning
> > >
> > >
> > > On Sun, Apr 21, 2019 at 11:30 PM Ning Wang <wa...@gmail.com>
> wrote:
> > >
> > > >
> > > >
> > > > On Fri, Apr 19, 2019 at 11:52 AM Ning Wang <wa...@gmail.com>
> > wrote:
> > > >
> > > >> Hi, dear Mentors,
> > > >>
> > > >> Please help if you have time. :) Thanks in advance.
> > > >>
> > > >> --ning
> > > >>
> > > >>
> > > >> On Fri, Apr 19, 2019 at 11:50 AM Ning Wang <wa...@gmail.com>
> > > wrote:
> > > >>
> > > >>> *Hello, Heron Community,*
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>> *This is a call for a vote to the 2nd release candidate for Apache
> > > >>> Heron, version v0.20.1-incubating. This is a second pass since Dave
> > > pointed
> > > >>> out a few things that we weren’t clear before. The git tag is the
> > same
> > > as
> > > >>> the last time and the previous votes (four +1s from thinker0,
> Karthik
> > > >>> Ramasamy, Josh Fischer, Simong Weng) will be carried over.The
> release
> > > will
> > > >>> be source only and I am going to remove the binary packages. We
> need
> > to
> > > >>> reduce the size and another review before including them in the
> > > release.The
> > > >>> tag to be voted upon:0.20.1-incubating-rc2
> > > >>> (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of changes
> > and
> > > >>> release notes are available
> > > >>> at:
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > >>> <
> > >
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > > >Release
> > > >>> files can be found in dist.apache.org <http://dist.apache.org>
> > > >>> site:
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > >>> <
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > > >Source:
> > > >>>
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > >>> <
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > > >ASC
> > > >>> signature:
> > > >>>
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > >>> <
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > > >SHA512:
> > > >>>
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > > >>> <
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > >
> >
> >c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3
> > > >>> incubator-heron-0.20.1-incubating-rc2.tar.gzThe artifacts are
> signed
> > > with
> > > >>> PGP key 293DB72F865688D1, corresponding to nwang@apache.org
> > > >>> <nw...@apache.org>, that can be found in keys
> > > >>> file:
> https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > >>> <https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > > >Please
> > > >>> download the source package, and follow the compiling
> > > >>> guide(
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > >>> <
> > >
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > > >)to
> > > >>> build and run the Heron locally. Note that currently Bazel 0.14.1
> is
> > > >>> required to build this version.For your convenience, here are a few
> > > >>> commands I used:License check:$ java -jar
> > > ~/Downloads/apache-rat-0.12.jar .
> > > >>> -E .rat-excludesBuild the binary package for Mac OS:$ sh
> > > >>> scripts/ci/build_release_packages.sh v0.20.1-incubating-rc2 darwin
> > > >>> artifactsBuild the docker image for Debian 9$ bash
> > > >>> scripts/ci/build_docker_image.sh v0.20.1-incubating-rc2 debian9
> > > >>> artifactsThe vote will be open for at least 72 hours or until the
> > > necessary
> > > >>> number of votes are reached. Hopefully we can get enough (three)
> > votes
> > > from
> > > >>> mentors.Please vote accordingly:[ ] +1 approve[ ] +0 no opinion[ ]
> -1
> > > >>> disapprove with the reasonThanks,The Apache Heron (Incubating)
> Team*
> > > >>>
> > > >>
> > >
> >
>
Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate
2 (Second Pass)
Posted by Ning Wang <wa...@gmail.com>.
Thans Julien!
For the release check instructions, here is a tracking ticket:
https://github.com/apache/incubator-heron/issues/3246
About the other questions:
Q: Do you have a way to tests for memory leaks as part of unit tests?
Yes. We have heap check with unit tests as well as integration tests.
Q: Do you have other ways to detect that as part of the release process?
Currently we are relying on integration tests. Internally we have a canary
process but externally users have very different environments and there is
no canary setup.
On Thu, Apr 25, 2019 at 9:29 PM Julien Le Dem
<ju...@wework.com.invalid> wrote:
> For what it's worth.
> I was able to build, verify the signature and run the rat report. So I was
> going to vote when thinker0 reported the issue.
> It would be nice to have clear an precise step by step instructions for
> validating the release. (and specifically the release)
> For example, the apache arrow project has a nice script that automates it
> all: https://github.com/apache/arrow/blob/master/dev/release/VERIFY.md
> That would improve the turn around on mentors voting on the release.
> Do you have a way to tests for memory leaks as part of unit tests?
> Do you have other ways to detect that as part of the release process?
> Thanks
> Julien
>
>
> On Thu, Apr 25, 2019 at 9:21 PM Ning Wang <wa...@gmail.com> wrote:
>
> > Hi,
> >
> > A memory leak issue was reported with this release, plus a fix is needed
> > for status script. I am closing this vote now and will prepare a new
> > release candidate after the issues are resolved.
> >
> > Thanks a lot for all the help!
> >
> > --ning
> >
> >
> > On Sun, Apr 21, 2019 at 11:30 PM Ning Wang <wa...@gmail.com> wrote:
> >
> > >
> > >
> > > On Fri, Apr 19, 2019 at 11:52 AM Ning Wang <wa...@gmail.com>
> wrote:
> > >
> > >> Hi, dear Mentors,
> > >>
> > >> Please help if you have time. :) Thanks in advance.
> > >>
> > >> --ning
> > >>
> > >>
> > >> On Fri, Apr 19, 2019 at 11:50 AM Ning Wang <wa...@gmail.com>
> > wrote:
> > >>
> > >>> *Hello, Heron Community,*
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> *This is a call for a vote to the 2nd release candidate for Apache
> > >>> Heron, version v0.20.1-incubating. This is a second pass since Dave
> > pointed
> > >>> out a few things that we weren’t clear before. The git tag is the
> same
> > as
> > >>> the last time and the previous votes (four +1s from thinker0, Karthik
> > >>> Ramasamy, Josh Fischer, Simong Weng) will be carried over.The release
> > will
> > >>> be source only and I am going to remove the binary packages. We need
> to
> > >>> reduce the size and another review before including them in the
> > release.The
> > >>> tag to be voted upon:0.20.1-incubating-rc2
> > >>> (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of changes
> and
> > >>> release notes are available
> > >>> at:
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > >>> <
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> > >Release
> > >>> files can be found in dist.apache.org <http://dist.apache.org>
> > >>> site:
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > >>> <
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> > >Source:
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > >>> <
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> > >ASC
> > >>> signature:
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > >>> <
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> > >SHA512:
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> > >>> <
> >
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> >
> >c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3
> > >>> incubator-heron-0.20.1-incubating-rc2.tar.gzThe artifacts are signed
> > with
> > >>> PGP key 293DB72F865688D1, corresponding to nwang@apache.org
> > >>> <nw...@apache.org>, that can be found in keys
> > >>> file:https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > >>> <https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> > >Please
> > >>> download the source package, and follow the compiling
> > >>> guide(
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > >>> <
> >
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> > >)to
> > >>> build and run the Heron locally. Note that currently Bazel 0.14.1 is
> > >>> required to build this version.For your convenience, here are a few
> > >>> commands I used:License check:$ java -jar
> > ~/Downloads/apache-rat-0.12.jar .
> > >>> -E .rat-excludesBuild the binary package for Mac OS:$ sh
> > >>> scripts/ci/build_release_packages.sh v0.20.1-incubating-rc2 darwin
> > >>> artifactsBuild the docker image for Debian 9$ bash
> > >>> scripts/ci/build_docker_image.sh v0.20.1-incubating-rc2 debian9
> > >>> artifactsThe vote will be open for at least 72 hours or until the
> > necessary
> > >>> number of votes are reached. Hopefully we can get enough (three)
> votes
> > from
> > >>> mentors.Please vote accordingly:[ ] +1 approve[ ] +0 no opinion[ ] -1
> > >>> disapprove with the reasonThanks,The Apache Heron (Incubating) Team*
> > >>>
> > >>
> >
>
Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate
2 (Second Pass)
Posted by Julien Le Dem <ju...@wework.com.INVALID>.
For what it's worth.
I was able to build, verify the signature and run the rat report. So I was
going to vote when thinker0 reported the issue.
It would be nice to have clear an precise step by step instructions for
validating the release. (and specifically the release)
For example, the apache arrow project has a nice script that automates it
all: https://github.com/apache/arrow/blob/master/dev/release/VERIFY.md
That would improve the turn around on mentors voting on the release.
Do you have a way to tests for memory leaks as part of unit tests?
Do you have other ways to detect that as part of the release process?
Thanks
Julien
On Thu, Apr 25, 2019 at 9:21 PM Ning Wang <wa...@gmail.com> wrote:
> Hi,
>
> A memory leak issue was reported with this release, plus a fix is needed
> for status script. I am closing this vote now and will prepare a new
> release candidate after the issues are resolved.
>
> Thanks a lot for all the help!
>
> --ning
>
>
> On Sun, Apr 21, 2019 at 11:30 PM Ning Wang <wa...@gmail.com> wrote:
>
> >
> >
> > On Fri, Apr 19, 2019 at 11:52 AM Ning Wang <wa...@gmail.com> wrote:
> >
> >> Hi, dear Mentors,
> >>
> >> Please help if you have time. :) Thanks in advance.
> >>
> >> --ning
> >>
> >>
> >> On Fri, Apr 19, 2019 at 11:50 AM Ning Wang <wa...@gmail.com>
> wrote:
> >>
> >>> *Hello, Heron Community,*
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> *This is a call for a vote to the 2nd release candidate for Apache
> >>> Heron, version v0.20.1-incubating. This is a second pass since Dave
> pointed
> >>> out a few things that we weren’t clear before. The git tag is the same
> as
> >>> the last time and the previous votes (four +1s from thinker0, Karthik
> >>> Ramasamy, Josh Fischer, Simong Weng) will be carried over.The release
> will
> >>> be source only and I am going to remove the binary packages. We need to
> >>> reduce the size and another review before including them in the
> release.The
> >>> tag to be voted upon:0.20.1-incubating-rc2
> >>> (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of changes and
> >>> release notes are available
> >>> at:
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> >>> <
> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2
> >Release
> >>> files can be found in dist.apache.org <http://dist.apache.org>
> >>> site:
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> >>> <
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/
> >Source:
> >>>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> >>> <
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz
> >ASC
> >>> signature:
> >>>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> >>> <
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc
> >SHA512:
> >>>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> >>> <
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512
> >c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3
> >>> incubator-heron-0.20.1-incubating-rc2.tar.gzThe artifacts are signed
> with
> >>> PGP key 293DB72F865688D1, corresponding to nwang@apache.org
> >>> <nw...@apache.org>, that can be found in keys
> >>> file:https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> >>> <https://dist.apache.org/repos/dist/release/incubator/heron/KEYS
> >Please
> >>> download the source package, and follow the compiling
> >>> guide(
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> >>> <
> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/
> >)to
> >>> build and run the Heron locally. Note that currently Bazel 0.14.1 is
> >>> required to build this version.For your convenience, here are a few
> >>> commands I used:License check:$ java -jar
> ~/Downloads/apache-rat-0.12.jar .
> >>> -E .rat-excludesBuild the binary package for Mac OS:$ sh
> >>> scripts/ci/build_release_packages.sh v0.20.1-incubating-rc2 darwin
> >>> artifactsBuild the docker image for Debian 9$ bash
> >>> scripts/ci/build_docker_image.sh v0.20.1-incubating-rc2 debian9
> >>> artifactsThe vote will be open for at least 72 hours or until the
> necessary
> >>> number of votes are reached. Hopefully we can get enough (three) votes
> from
> >>> mentors.Please vote accordingly:[ ] +1 approve[ ] +0 no opinion[ ] -1
> >>> disapprove with the reasonThanks,The Apache Heron (Incubating) Team*
> >>>
> >>
>