You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Dmitry Gusev (Created) (JIRA)" <ji...@apache.org> on 2012/03/09 10:44:04 UTC
[jira] [Created] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
----------------------------------------------------------------------------------------------------------------
Key: TAP5-1868
URL: https://issues.apache.org/jira/browse/TAP5-1868
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.3.2
Reporter: Dmitry Gusev
Cache lookup ignores StreamableResourceProcessing argument.
public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
{
...
public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
throws IOException
{
if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
{
return delegate.getStreamableResource(baseResource, processing, dependencies);
}
StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
if (result == null)
{
result = delegate.getStreamableResource(baseResource, processing, dependencies);
if (isCacheable(result))
{
dependencies.addDependency(baseResource);
cache.put(baseResource, new SoftReference<StreamableResource>(result));
}
}
return result;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1868.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.3.5
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1868:
---------------------------------------
Fix Version/s: (was: 5.3.5)
5.3.6
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.6
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1868:
---------------------------------------
Labels: fixed-in-5.4-js-rewrite (was: )
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Dmitry Gusev (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1868:
-------------------------------
Priority: Minor (was: Major)
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Priority: Minor
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1868:
---------------------------------------
Fix Version/s: (was: 5.3.5)
5.3.6
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.6
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Dmitry Gusev (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1868:
-------------------------------
Priority: Minor (was: Major)
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Priority: Minor
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1868:
---------------------------------------
Priority: Major (was: Minor)
Assignee: Howard M. Lewis Ship
I believe the same logic is causing the headache of changing an asset source (such as a JavaScript library) and not seeing the change in the browser, as the cached gzip version is still sent back to the browser.
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1868:
---------------------------------------
Fix Version/s: (was: 5.3.6)
5.3.5
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1868:
---------------------------------------
Fix Version/s: (was: 5.3.6)
5.3.5
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1868:
---------------------------------------
Labels: fixed-in-5.4-js-rewrite (was: )
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reopened TAP5-1868:
----------------------------------------
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1868.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.3.5
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reopened TAP5-1868:
----------------------------------------
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1868) SRSCachingInterceptor returns
compressed version of asset for all clients once it was compressed for some
client
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1868:
---------------------------------------
Priority: Major (was: Minor)
Assignee: Howard M. Lewis Ship
I believe the same logic is causing the headache of changing an asset source (such as a JavaScript library) and not seeing the change in the browser, as the cached gzip version is still sent back to the browser.
> SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing, dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing, dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira