You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org> on 2011/03/04 16:30:37 UTC
[jira] Commented: (HADOOP-7131) set() and toString Methods of the
org.apache.hadoop.io.Text class does not include the root exception, in the
wrapping RuntimeException.
[ https://issues.apache.org/jira/browse/HADOOP-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002667#comment-13002667 ]
Uma Maheswara Rao G commented on HADOOP-7131:
---------------------------------------------
Here the verification results:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
Tests are not required for this changes. that is the reason for -1.
> set() and toString Methods of the org.apache.hadoop.io.Text class does not include the root exception, in the wrapping RuntimeException.
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7131
> URL: https://issues.apache.org/jira/browse/HADOOP-7131
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.20.1, 0.20.2
> Reporter: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HADOOP-7131.patch
>
>
> In below code snippets, we can include e, instead of e.toString(), so that caller can get complete trace.
> 1)
> /** Set to contain the contents of a string.
> */
> public void set(String string) {
> try {
> ByteBuffer bb = encode(string, true);
> bytes = bb.array();
> length = bb.limit();
> }catch(CharacterCodingException e) {
> throw new RuntimeException("Should not have happened ",e.toString());
> }
> }
> 2)
> public String toString() {
> try {
> return decode(bytes, 0, length);
> } catch (CharacterCodingException e) {
> throw new RuntimeException("Should not have happened ",e.toString());
> }
> }
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira