You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 02:56:26 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #131: chore: refactor conf/ directory
tokers opened a new pull request #131:
URL: https://github.com/apache/apisix-ingress-controller/pull/131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #131: chore: refactor conf/ directory
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #131:
URL: https://github.com/apache/apisix-ingress-controller/pull/131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #131: chore: refactor conf/ directory
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #131:
URL: https://github.com/apache/apisix-ingress-controller/pull/131#discussion_r548890838
##########
File path: conf/config-default.json
##########
@@ -0,0 +1,13 @@
+{
+ "log_level": "info",
+ "log_output": "stderr",
+ "http_listen": ":8080",
+ "enable_profiling": true,
+ "kubernetes": {
+ "kubeconfig": "",
+ "resync_interval": "60s"
+ },
+ "apisix": {
+ "base_url": "http://127.0.0.1:9080/apisix/admin"
+ }
+}
Review comment:
There is no place to use this file in the code.
Is the purpose of this file to give users a configuration example ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #131: chore: refactor conf/ directory
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #131:
URL: https://github.com/apache/apisix-ingress-controller/pull/131#discussion_r548930435
##########
File path: conf/config-default.json
##########
@@ -0,0 +1,13 @@
+{
+ "log_level": "info",
+ "log_output": "stderr",
+ "http_listen": ":8080",
+ "enable_profiling": true,
+ "kubernetes": {
+ "kubeconfig": "",
+ "resync_interval": "60s"
+ },
+ "apisix": {
+ "base_url": "http://127.0.0.1:9080/apisix/admin"
+ }
+}
Review comment:
Two example configuration files, one is in `yaml` and another is in `json`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org