You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2019/09/30 02:06:52 UTC

[GitHub] [groovy] paulk-asert commented on issue #1013: Remove antlr2 related code in `LexerFrame`

paulk-asert commented on issue #1013: Remove antlr2 related code in `LexerFrame`
URL: https://github.com/apache/groovy/pull/1013#issuecomment-536371369
 
 
   Maybe we should set  up a parallel package, e.g. org.apache.groovy.antlr.LexerFrame
   We could leave the codehaus one generic supporting other lexer/tokentype combinations but deprecate it.
   Then perhaps for the new apache version hard code the tokenTypesClass class as well as the lexerClass (not just the lexerClass as in this PR)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services