You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/13 15:27:41 UTC

[GitHub] kaxil commented on a change in pull request #3744: [AIRFLOW-2893] fix stuck dataflow job due to name mismatch

kaxil commented on a change in pull request #3744: [AIRFLOW-2893] fix stuck dataflow job due to name mismatch
URL: https://github.com/apache/incubator-airflow/pull/3744#discussion_r209652868
 
 

 ##########
 File path: tests/contrib/hooks/test_gcp_dataflow_hook.py
 ##########
 @@ -24,6 +24,7 @@
 
 from airflow.contrib.hooks.gcp_dataflow_hook import DataFlowHook
 from airflow.contrib.hooks.gcp_dataflow_hook import _Dataflow
+from airflow.contrib.hooks.gcp_dataflow_hook import _DataflowJob
 
 Review comment:
   Can we get all the imports inline?
   
   ```
   from airflow.contrib.hooks.gcp_dataflow_hook import DataFlowHook, _Dataflow, _DataflowJob
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services