[GitHub] [incubator-superset] etr2460 commented on a change in pull request #7572: [SQL Lab] Show warning when user used up localStorage

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #7572: [SQL Lab] Show warning when user used up localStorage
URL: https://github.com/apache/incubator-superset/pull/7572#discussion_r288764614
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/App.jsx
 ##########
 @@ -21,27 +21,39 @@ import PropTypes from 'prop-types';
 import { bindActionCreators } from 'redux';
 import { connect } from 'react-redux';
 import $ from 'jquery';
+import { t } from '@superset-ui/translation';
+import debounce from 'lodash/debounce';
 
 import TabbedSqlEditors from './TabbedSqlEditors';
 import QueryAutoRefresh from './QueryAutoRefresh';
 import QuerySearch from './QuerySearch';
 import ToastPresenter from '../../messageToasts/containers/ToastPresenter';
 import * as Actions from '../actions/sqlLab';
 
+// Upper limits for localStorage usage.
+const SQLLAB_LOCALSTORAGE_MAX = 5120;
 
 Review comment:
   Define a unit here too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org