[GitHub] [incubator-superset] villebro commented on a change in pull request #9586: [mypy] Enforcing typing for a number of modules

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9586:
URL: https://github.com/apache/incubator-superset/pull/9586#discussion_r414660726



##########
File path: superset/connectors/druid/models.py
##########
@@ -823,6 +823,7 @@ def granularity(
 
         if origin:
             dttm = utils.parse_human_datetime(origin)
+            assert dttm

Review comment:
       Agreed; was going to ask if we could do that change already now, but I expect this to be a Pandora's box, and probably warrants a separate PR to isolate regression risk.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org