[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8342: use Number instead of long for response context

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8342: use Number instead of long for response context
URL: https://github.com/apache/incubator-druid/pull/8342#discussion_r315474913
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/query/context/ResponseContextTest.java
 ##########
 @@ -285,6 +285,8 @@ public void deserializeTest() throws IOException
     );
     Assert.assertEquals("string-value", ctx.get(ResponseContext.Key.ETAG));
     Assert.assertEquals(100, ctx.get(ResponseContext.Key.NUM_SCANNED_ROWS));
+    ctx.add(ResponseContext.Key.NUM_SCANNED_ROWS, 10L);
+    Assert.assertEquals(110L, ctx.get(ResponseContext.Key.NUM_SCANNED_ROWS));
 
 Review comment:
   the code is equivalent making a test sort of redundant, but yes anything is possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org