You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by yo...@apache.org on 2005/11/10 19:44:57 UTC

svn commit: r332351 - in /tomcat/container/tc5.5.x: catalina/src/bin/catalina.bat webapps/docs/changelog.xml

Author: yoavs
Date: Thu Nov 10 10:44:53 2005
New Revision: 332351

URL: http://svn.apache.org/viewcvs?rev=332351&view=rev
Log:
Bugzilla 37319: http://issues.apache.org/bugzilla/show_bug.cgi?id=37319

Modified:
    tomcat/container/tc5.5.x/catalina/src/bin/catalina.bat
    tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/catalina/src/bin/catalina.bat
URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/bin/catalina.bat?rev=332351&r1=332350&r2=332351&view=diff
==============================================================================
--- tomcat/container/tc5.5.x/catalina/src/bin/catalina.bat (original)
+++ tomcat/container/tc5.5.x/catalina/src/bin/catalina.bat Thu Nov 10 10:44:53 2005
@@ -78,7 +78,7 @@
 :gotTmpdir
 
 if not exist "%CATALINA_HOME%\bin\tomcat-juli.jar" goto noJuli
-set JAVA_OPTS=%JAVA_OPTS% -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -Djava.util.logging.config.file="${catalina.base}\conf\logging.properties"
+set JAVA_OPTS=%JAVA_OPTS% -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -Djava.util.logging.config.file="%CATALINA_BASE\conf\logging.properties"
 :noJuli
 
 rem ----- Execute The Requested Command ---------------------------------------

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=332351&r1=332350&r2=332351&view=diff
==============================================================================
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Thu Nov 10 10:44:53 2005
@@ -68,6 +68,10 @@
         <bug>37150</bug>: Turn off directory listing by default and add a warning
         regarding enabling listing of directories with many entries. (markt)
       </fix>
+      <fix>
+        <bug>37319</bug>: Fix catalina.bat reference to CATALINA_BASE for logging.properties.  Thanks
+        to Pierre-Yves Benzaken. (yoavs)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Coyote">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r332351 - in /tomcat/container/tc5.5.x: catalina/src/bin/catalina.bat webapps/docs/changelog.xml

Posted by Shankar Unni <sh...@netscape.net>.
Remy Maucherat wrote:
> yoavs@apache.org wrote:
>> Author: yoavs
>> Date: Thu Nov 10 10:44:53 2005
>> New Revision: 332351
>>
>> URL: http://svn.apache.org/viewcvs?rev=332351&view=rev
>> Log:
>> Bugzilla 37319: http://issues.apache.org/bugzilla/show_bug.cgi?id=37319
>>
>> Modified:
>>     tomcat/container/tc5.5.x/catalina/src/bin/catalina.bat
>>     tomcat/container/tc5.5.x/webapps/docs/changelog.xml
> 
> I use Windows, and use exclusively catalina.bat. It works fine (in the 
> code, you'll see that there is replacement code for system properties - 
> the installer uses them, please don't "fix" that occurrence ;) ), and 
> will (hopefully) work just as fine with the fix.


Besides, Yoavs' fix has a problem in it: it says

-Djava.util.logging.config.file="%CATALINA_BASE\conf\logging.properties"

notice the missing closing "%" after CATALINA_BASE..


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r332351 - in /tomcat/container/tc5.5.x: catalina/src/bin/catalina.bat webapps/docs/changelog.xml

Posted by Remy Maucherat <re...@apache.org>.
yoavs@apache.org wrote:
> Author: yoavs
> Date: Thu Nov 10 10:44:53 2005
> New Revision: 332351
> 
> URL: http://svn.apache.org/viewcvs?rev=332351&view=rev
> Log:
> Bugzilla 37319: http://issues.apache.org/bugzilla/show_bug.cgi?id=37319
> 
> Modified:
>     tomcat/container/tc5.5.x/catalina/src/bin/catalina.bat
>     tomcat/container/tc5.5.x/webapps/docs/changelog.xml

I use Windows, and use exclusively catalina.bat. It works fine (in the 
code, you'll see that there is replacement code for system properties - 
the installer uses them, please don't "fix" that occurrence ;) ), and 
will (hopefully) work just as fine with the fix.

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org