You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by jun aoki <ju...@gmail.com> on 2014/09/04 03:24:53 UTC
Review Request 25322: AMBARI-6639 License of Font Awesome is wrong in
NOTICE.txt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25322/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-6639
https://issues.apache.org/jira/browse/AMBARI-6639
Repository: ambari
Description
-------
Fixed the note.
Diffs
-----
ambari-web/app/assets/licenses/NOTICE.txt 9be0e09
Diff: https://reviews.apache.org/r/25322/diff/
Testing
-------
Thanks,
jun aoki
Re: Review Request 25322: AMBARI-6639 License of Font Awesome is
wrong in NOTICE.txt
Posted by jun aoki <ju...@gmail.com>.
Hi Mahadev, I re-attached the patch.
On Mon, Sep 8, 2014 at 2:04 PM, jun aoki <ju...@gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25322/
> Review request for Ambari.
> By jun aoki.
>
> *Updated Sept. 8, 2014, 9:04 p.m.*
> Changes
>
> recreated a patch since the base has been changed. the code change is identical as the previous one.
>
> *Bugs: * AMBARI-6639 <https://issues.apache.org/jira/browse/AMBARI-6639>
> *Repository: * ambari
> Description
>
> Fixed the note.
>
> Diffs (updated)
>
> - ambari-web/app/assets/licenses/NOTICE.txt (d317866)
>
> View Diff <https://reviews.apache.org/r/25322/diff/>
>
--
-jun
Re: Review Request 25322: AMBARI-6639 License of Font Awesome is
wrong in NOTICE.txt
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25322/
-----------------------------------------------------------
(Updated Sept. 8, 2014, 9:04 p.m.)
Review request for Ambari.
Changes
-------
recreated a patch since the base has been changed. the code change is identical as the previous one.
Bugs: AMBARI-6639
https://issues.apache.org/jira/browse/AMBARI-6639
Repository: ambari
Description
-------
Fixed the note.
Diffs (updated)
-----
ambari-web/app/assets/licenses/NOTICE.txt d317866
Diff: https://reviews.apache.org/r/25322/diff/
Testing
-------
Thanks,
jun aoki
Re: Review Request 25322: AMBARI-6639 License of Font Awesome is
wrong in NOTICE.txt
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25322/#review52538
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On Sept. 4, 2014, 1:24 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25322/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 1:24 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-6639
> https://issues.apache.org/jira/browse/AMBARI-6639
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed the note.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/licenses/NOTICE.txt 9be0e09
>
> Diff: https://reviews.apache.org/r/25322/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 25322: AMBARI-6639 License of Font Awesome is
wrong in NOTICE.txt
Posted by jun aoki <ju...@gmail.com>.
Hi Mahadev, thank you for letting me know . I will remake the patch.
On Mon, Sep 8, 2014 at 1:36 PM, Mahadev Konar <ma...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25322/
>
> jun the patch doesnt apply looks like still - tried dwonloading and applying it and it fails. Are you sure it applies on trunk?
>
>
> - Mahadev Konar
>
> On September 4th, 2014, 1:24 a.m. UTC, jun aoki wrote:
> Review request for Ambari.
> By jun aoki.
>
> *Updated Sept. 4, 2014, 1:24 a.m.*
> *Bugs: * AMBARI-6639 <https://issues.apache.org/jira/browse/AMBARI-6639>
> *Repository: * ambari
> Description
>
> Fixed the note.
>
> Diffs
>
> - ambari-web/app/assets/licenses/NOTICE.txt (9be0e09)
>
> View Diff <https://reviews.apache.org/r/25322/diff/>
>
--
-jun
Re: Review Request 25322: AMBARI-6639 License of Font Awesome is
wrong in NOTICE.txt
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25322/#review52629
-----------------------------------------------------------
jun the patch doesnt apply looks like still - tried dwonloading and applying it and it fails. Are you sure it applies on trunk?
- Mahadev Konar
On Sept. 4, 2014, 1:24 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25322/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 1:24 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-6639
> https://issues.apache.org/jira/browse/AMBARI-6639
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed the note.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/licenses/NOTICE.txt 9be0e09
>
> Diff: https://reviews.apache.org/r/25322/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>